Update lmms to 1.2.1
ClosedPublic
Actions

Authored by Jacalz on Oct 22 2019, 5:24 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R1974:8517f82687d4: Update lmms to 1.2.1

Summary

Summarized Changelog:

Depends on D7472

Packaging Changes:

Test Plan

Repository

R1974 lmms

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Jacalz requested review of this revision.Oct 22 2019, 5:24 PM

I can step up to officially maintain the package if the core team so desires? If yes, I will add a MAINTAINERS file :)

JoshStrobl requested changes to this revision.Oct 23 2019, 4:31 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
37	If anything this should remain and we should remove `-DWANT_VST_NOWINE=ON` and make sure the VST bits it needs via WINE are properly enabled https://github.com/LMMS/lmms/blob/master/CMakeLists.txt#L456
40	Is this still not accurate? Because you're not including the pkgconfig anywhere and it was previously explicit that it should be off. You're reducing the amount of useful information on why specific flags are disabled.

This revision now requires changes to proceed.Oct 23 2019, 4:31 PM

Jacalz marked an inline comment as done.Oct 23 2019, 5:03 PM

Jacalz added inline comments.

package.yml
40	Sorry. I forgot to send up the patch that fixes the runtime dependencies for `libgig`.

Add back libgig support that I forgot to do yesterday

Clean up 32bit deps

package.yml
37	I just can't get it to build with full wine support. ld fails on trying to find libpthread and that is installed correctly with `libpth-32bit-devel`. It shouldn't be a problem but I am still running in to linking problems, just like last time I tried it :(