Paths

Table of Contentst

Differential D7466

Update lmms to 1.2.1
ClosedPublic
Actions

Authored by Jacalz on Oct 22 2019, 5:24 PM.

Tags

None

Referenced Files

	F11037613: D7466.diff
	Wed, Aug 9, 8:59 PM

	F11019093: D7466.id17897.diff
	Sun, Aug 6, 5:21 PM

	F11017638: D7466.diff
	Sun, Aug 6, 4:14 AM

	F11008724: D7466.diff
	Wed, Aug 2, 5:40 AM

	F10996139: D7466.id17897.diff
	Wed, Jul 26, 11:42 AM

	F10984346: D7466.id17920.diff
	Sun, Jul 23, 5:26 PM

	F10893312: D7466.id17922.diff
	Jun 30 2023, 5:28 PM

	F10888674: D7466.diff
	Jun 27 2023, 6:23 AM

View All 20 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R1974:8517f82687d4: Update lmms to 1.2.1

Summary

Summarized Changelog:

Respect OS' case sensitivity when checking for existing files.
Remove MIDI connections from factory .mmpz files.
Make splash screen text white.
Show Beat/Bassline Editor on clicking track labels of B/B tracks.
Fix stuck keys when dragging on the piano view.
Fix crash on unmarking octave semitones.
Fix invalid MIDI Program Change decoding.
Rubberband fix for selecting a large area in the song editor.
Organic: fix glitch at the beginning of a note.
Fix broken audio sample exporting on high sampling rate.
Better French translations in the menu item file.
Fix too long translations to fix the UI misalignment.

Depends on D7472

Packaging Changes:

Added support for libgig to make the gigplayer work.

Test Plan

Make a song and export both midi and mp3 files to play.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Jacalz created this revision.Oct 22 2019, 5:24 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 22 2019, 5:24 PM

Jacalz requested review of this revision.Oct 22 2019, 5:24 PM

I can step up to officially maintain the package if the core team so desires? If yes, I will add a MAINTAINERS file :)

JoshStrobl requested changes to this revision.Oct 23 2019, 4:31 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
37	If anything this should remain and we should remove `-DWANT_VST_NOWINE=ON` and make sure the VST bits it needs via WINE are properly enabled https://github.com/LMMS/lmms/blob/master/CMakeLists.txt#L456
40	Is this still not accurate? Because you're not including the pkgconfig anywhere and it was previously explicit that it should be off. You're reducing the amount of useful information on why specific flags are disabled.

This revision now requires changes to proceed.Oct 23 2019, 4:31 PM

Jacalz marked an inline comment as done.Oct 23 2019, 5:03 PM

Jacalz added inline comments.

package.yml
40	Sorry. I forgot to send up the patch that fixes the runtime dependencies for `libgig`.

Jacalz edited the summary of this revision. (Show Details)Oct 23 2019, 5:04 PM

Jacalz added a parent revision: D7472: Make runtime dependencies on libgig possible.

Add back libgig support that I forgot to do yesterday

Clean up 32bit deps

Jacalz added inline comments.Oct 23 2019, 5:23 PM

package.yml
37	I just can't get it to build with full wine support. ld fails on trying to find libpthread and that is installed correctly with `libpth-32bit-devel`. It shouldn't be a problem but I am still running in to linking problems, just like last time I tried it :(

Fair enough, patch LGTM. Thanks for the work :)

This revision is now accepted and ready to land.Oct 23 2019, 6:54 PM

Closed by commit R1974:8517f82687d4: Update lmms to 1.2.1 (authored by Jacalz, committed by JoshStrobl). · Explain WhyOct 23 2019, 7:14 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R1974:8517f82687d4: Update lmms to 1.2.1.

Jacalz mentioned this in T5055: LMMS lacks certain instruments.Nov 11 2019, 6:08 PM

Revision Contents
Changeset List

Path

Size

8 lines

12 lines

pspec_x86_64.xml

17 lines

Diff 17935

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...