Page MenuHomeSolus

Update lmms to 1.2.1
ClosedPublic

Authored by Jacalz on Oct 22 2019, 5:24 PM.

Details

Summary

Summarized Changelog:

  • Respect OS' case sensitivity when checking for existing files.
  • Remove MIDI connections from factory .mmpz files.
  • Make splash screen text white.
  • Show Beat/Bassline Editor on clicking track labels of B/B tracks.
  • Fix stuck keys when dragging on the piano view.
  • Fix crash on unmarking octave semitones.
  • Fix invalid MIDI Program Change decoding.
  • Rubberband fix for selecting a large area in the song editor.
  • Organic: fix glitch at the beginning of a note.
  • Fix broken audio sample exporting on high sampling rate.
  • Better French translations in the menu item file.
  • Fix too long translations to fix the UI misalignment.

Depends on D7472

Packaging Changes:

  • Added support for libgig to make the gigplayer work.
Test Plan
  • Make a song and export both midi and mp3 files to play.

Diff Detail

Repository
R1974 lmms
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Oct 22 2019, 5:24 PM
Jacalz requested review of this revision.Oct 22 2019, 5:24 PM

I can step up to officially maintain the package if the core team so desires? If yes, I will add a MAINTAINERS file :)

JoshStrobl requested changes to this revision.Oct 23 2019, 4:31 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
37

If anything this should remain and we should remove -DWANT_VST_NOWINE=ON and make sure the VST bits it needs via WINE are properly enabled https://github.com/LMMS/lmms/blob/master/CMakeLists.txt#L456

40

Is this still not accurate? Because you're not including the pkgconfig anywhere and it was previously explicit that it should be off. You're reducing the amount of useful information on why specific flags are disabled.

This revision now requires changes to proceed.Oct 23 2019, 4:31 PM
Jacalz marked an inline comment as done.Oct 23 2019, 5:03 PM
Jacalz added inline comments.
package.yml
40

Sorry. I forgot to send up the patch that fixes the runtime dependencies for libgig.

Jacalz edited the summary of this revision. (Show Details)Oct 23 2019, 5:04 PM
Jacalz updated this revision to Diff 17920.Oct 23 2019, 5:08 PM
Jacalz marked an inline comment as done.

Add back libgig support that I forgot to do yesterday

Jacalz updated this revision to Diff 17922.Oct 23 2019, 5:21 PM

Clean up 32bit deps

Jacalz added inline comments.Oct 23 2019, 5:23 PM
package.yml
37

I just can't get it to build with full wine support. ld fails on trying to find libpthread and that is installed correctly with libpth-32bit-devel. It shouldn't be a problem but I am still running in to linking problems, just like last time I tried it :(

JoshStrobl accepted this revision.Oct 23 2019, 6:54 PM

Fair enough, patch LGTM. Thanks for the work :)

This revision is now accepted and ready to land.Oct 23 2019, 6:54 PM
This revision was automatically updated to reflect the committed changes.