Page MenuHomeSolus

Merge python-gobject and python3-gobject
AbandonedPublic

Authored by livingsilver94 on Oct 20 2019, 8:54 PM.

Details

Summary

Merge python-gobject and python3-gobject.
Fixes T3904.

Test Plan

Rebuilt ibus-anthy, caribou, network-manager, firewalld.

Diff Detail

Repository
R2512 python-gobject
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

livingsilver94 created this revision.Oct 20 2019, 8:54 PM
livingsilver94 requested review of this revision.Oct 20 2019, 8:54 PM
JoshStrobl requested changes to this revision.Oct 23 2019, 4:48 PM
JoshStrobl added a subscriber: JoshStrobl.

You need to do a replaces on python3-gobject and python3-gobject-devel, while I ponder the meaning of life and any consequences of this merge.

Test Plan
Not needed?

Except ya know, it is? You should be compiling against this new python-gobject-devel package, as an example, across both python2 and python3 applications.

package.yml
2–3

This needs to be bumped higher than python3-gobject otherwise it'll fail to land in the repo due to being same relnum (or less than).

This revision now requires changes to proceed.Oct 23 2019, 4:48 PM

Except ya know, it is? You should be compiling against this new python-gobject-devel package, as an example, across both python2 and python3 applications.

OK, see ya in a few years!

Bump to rel 18 and add replaces

Except ya know, it is? You should be compiling against this new python-gobject-devel package, as an example, across both python2 and python3 applications.

Nothing requires python*-gobject-devel though, gobject is only required as a rundep. I checked that with eopkg info.

JoshStrobl requested changes to this revision.Oct 23 2019, 7:15 PM

Nothing requires python*-gobject-devel though, gobject is only required as a rundep.

Just because nothing is marked as a revdep (which doesn't happen with python unless you explicitly make rundeps) doesn't mean the pkgconfig or the pkg names aren't marked as builddeps.

This revision now requires changes to proceed.Oct 23 2019, 7:15 PM

Oops. Right, I derped.

❯ for file in $(find -name package.yml); do; grep -H python-gobject-devel $file; done
./ibus-anthy/package.yml:    - python-gobject-devel
./caribou/package.yml:    - python-gobject-devel
./network-manager/package.yml:    - python-gobject-devel
./firewalld/package.yml:    - python-gobject-devel # check

I'm going to rebuild these.

livingsilver94 added a comment.EditedOct 26 2019, 11:29 PM

I'm not sure whether to rebuild packages using pkgconfig(pygobject-3.0) given that it was pointing to two packages...

livingsilver94 edited the test plan for this revision. (Show Details)Nov 8 2019, 3:16 PM
DataDrake requested changes to this revision.Feb 5 2020, 2:26 PM
DataDrake added a subscriber: DataDrake.

This will need a rebuild for python 3.7.

Rebase against Python3.7

DataDrake accepted this revision.Apr 15 2020, 3:46 PM

LGTM. Thanks!

JoshStrobl accepted this revision.Apr 15 2020, 3:49 PM
This revision is now accepted and ready to land.Apr 15 2020, 3:49 PM
DataDrake abandoned this revision.Thu, Jun 18, 1:37 PM

Thanks for this, I'll save you the rebase.