Page MenuHomeSolus
Differential D7429

initial inclusion of kcalendarcore replaces kcalcore
ClosedPublic
Actions

Authored by Girtablulu on Oct 18 2019, 12:06 PM.
Tags
None
Referenced Files
F11058437: D7429.diff
Fri, Aug 11, 6:25 AM
F11052430: D7429.id17849.diff
Thu, Aug 10, 9:22 PM
F11052429: D7429.id.diff
Thu, Aug 10, 9:22 PM
F11052428: D7429.id17999.diff
Thu, Aug 10, 9:22 PM
F11052427: D7429.id17863.diff
Thu, Aug 10, 9:21 PM
F11052426: D7429.id17855.diff
Thu, Aug 10, 9:21 PM
F11052425: D7429.id17850.diff
Thu, Aug 10, 9:21 PM
F11037064: D7429.diff
Wed, Aug 9, 8:02 PM
View All 30 Files
Subscribers
JoshStrobl
maverick1

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R4849:2a4259f7597d: initial inclusion of kcalendarcore replaces kcalcore
Summary

initial inclusion of kcalendacore replaces kcalcore

Test Plan

is just a new package name, nothing changes between kcalcore and kcalendarcore

Diff Detail

Repository
R4849 kcalendarcore
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Girtablulu created this revision.Oct 18 2019, 12:06 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptOct 18 2019, 12:06 PM
Girtablulu requested review of this revision.Oct 18 2019, 12:06 PM
JoshStrobl requested changes to this revision.Oct 18 2019, 12:18 PM
JoshStrobl retitled this revision from initial inclusion of kcalendacore replaces kcalcore to initial inclusion of kcalendarcore replaces kcalcore.
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
18

You need to do the same for the devel sub-package + kcalcore-devel

This revision now requires changes to proceed.Oct 18 2019, 12:19 PM
Girtablulu updated this revision to Diff 17850.Oct 18 2019, 1:07 PM

Add -devel replacement

JoshStrobl requested changes to this revision.Oct 18 2019, 4:04 PM
JoshStrobl added inline comments.
package.yml
20

Can just be: - devel : kcalcore-devel and add in - dbginfo: kcalcore-dbginfo while we're at it just in case there's like...one person that has it.

This revision now requires changes to proceed.Oct 18 2019, 4:04 PM
Girtablulu updated this revision to Diff 17855.Oct 18 2019, 4:23 PM

Add dbginfo as well

Girtablulu updated this revision to Diff 17863.Oct 18 2019, 8:04 PM

eopkg doesn't know how to replace dbginfo

JoshStrobl accepted this revision.Oct 19 2019, 2:55 AM

LGTM but before you push this, please ping me on Discord so I can fire up my laptop and coordinate with you on landing the repo-side deprecations. Thanks!

This revision is now accepted and ready to land.Oct 19 2019, 2:55 AM
Girtablulu added a comment.Oct 19 2019, 7:43 AM

ai will do, but will be the last thing I do

Girtablulu added a comment.Oct 19 2019, 8:07 AM

https://github.com/getsolus/solus-sc/pull/29

maverick1 added a subscriber: maverick1.Oct 20 2019, 5:30 AM
maverick1 added inline comments.
package.yml
16

I don't know much but I think package config will be better than the package-devel. Corresponding pkgconfig: pkgconfig(libical)

JoshStrobl added inline comments.Oct 20 2019, 5:59 AM
package.yml
16

While I appreciate the feedback on patches, please refrain from reviewing patches. That is for the Triage Team, Global Maintainers, and Core Team to do. Thanks.

Closed by commit R4849:2a4259f7597d: initial inclusion of kcalendarcore replaces kcalcore (authored by Girtablulu). · Explain WhyOct 26 2019, 4:56 PM
This revision was automatically updated to reflect the committed changes.
Girtablulu added a commit: R4849:2a4259f7597d: initial inclusion of kcalendarcore replaces kcalcore.

Revision Contents
Changeset List

PathSize
1 line
1104 lines
7 lines
24 lines
186 lines

Diff 17999

View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.