Page MenuHomeSolus

initial inclusion of kcalendarcore replaces kcalcore
ClosedPublic

Authored by Girtablulu on Oct 18 2019, 12:06 PM.

Details

Summary

initial inclusion of kcalendacore replaces kcalcore

Test Plan

is just a new package name, nothing changes between kcalcore and kcalendarcore

Diff Detail

Repository
R4849 kcalendarcore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Oct 18 2019, 12:06 PM
Girtablulu requested review of this revision.Oct 18 2019, 12:06 PM
JoshStrobl requested changes to this revision.Oct 18 2019, 12:18 PM
JoshStrobl retitled this revision from initial inclusion of kcalendacore replaces kcalcore to initial inclusion of kcalendarcore replaces kcalcore.
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
18

You need to do the same for the devel sub-package + kcalcore-devel

This revision now requires changes to proceed.Oct 18 2019, 12:19 PM
Girtablulu updated this revision to Diff 17850.Oct 18 2019, 1:07 PM

Add -devel replacement

JoshStrobl requested changes to this revision.Oct 18 2019, 4:04 PM
JoshStrobl added inline comments.
package.yml
20

Can just be: - devel : kcalcore-devel and add in - dbginfo: kcalcore-dbginfo while we're at it just in case there's like...one person that has it.

This revision now requires changes to proceed.Oct 18 2019, 4:04 PM
Girtablulu updated this revision to Diff 17855.Oct 18 2019, 4:23 PM

Add dbginfo as well

Girtablulu updated this revision to Diff 17863.Oct 18 2019, 8:04 PM

eopkg doesn't know how to replace dbginfo

JoshStrobl accepted this revision.Oct 19 2019, 2:55 AM

LGTM but before you push this, please ping me on Discord so I can fire up my laptop and coordinate with you on landing the repo-side deprecations. Thanks!

This revision is now accepted and ready to land.Oct 19 2019, 2:55 AM

ai will do, but will be the last thing I do

maverick1 added inline comments.
package.yml
16

I don't know much but I think package config will be better than the package-devel. Corresponding pkgconfig: pkgconfig(libical)

JoshStrobl added inline comments.Oct 20 2019, 5:59 AM
package.yml
16

While I appreciate the feedback on patches, please refrain from reviewing patches. That is for the Triage Team, Global Maintainers, and Core Team to do. Thanks.