Page MenuHomeSolus

Update Keybase to 4.6.1
ClosedPublic

Authored by Staudey on Oct 16 2019, 6:24 PM.

Details

Summary

Update Keybase to 4.6.1

Technically only contains Windows fixes, but here's to hoping that this version builds again on our server

Test Plan

Sent a few chat messages, checked my wallet, downloaded a file

Diff Detail

Repository
R4442 keybase
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Oct 16 2019, 6:24 PM
Staudey requested review of this revision.Oct 16 2019, 6:24 PM
algent added a subscriber: algent.Oct 17 2019, 7:36 AM
This comment was removed by JoshStrobl.
Jacalz added a subscriber: Jacalz.EditedOct 17 2019, 7:42 AM

I believe that git will be installed from the git fetch of the version (git|https://github.com/keybase/client : v4.6.1), in other words you should be able to remove it that from the builddeps as well.

How about I stick with the reviews? Thanks.

JoshStrobl accepted this revision.Oct 17 2019, 9:31 AM

LGTM, let's get this landed so we can get new keybase in repo. Maybe a future commit can focus on cleaning up those builddeps a bit?

This revision is now accepted and ready to land.Oct 17 2019, 9:31 AM
This revision was automatically updated to reflect the committed changes.

Just an FYI, this build successfully on the server and should now be in the repo. Thanks again.