Page MenuHomeSolus
Differential D7415

Initial inclution of flask-httpauth, needed for onionshare
ClosedPublic
Actions

Authored by Jacalz on Oct 16 2019, 5:17 PM.
Tags
None
Referenced Files
F11052301: D7415.id.diff
Thu, Aug 10, 9:15 PM
F11052300: D7415.id17774.diff
Thu, Aug 10, 9:15 PM
F11052299: D7415.id17833.diff
Thu, Aug 10, 9:15 PM
F11052298: D7415.id17828.diff
Thu, Aug 10, 9:15 PM
F11037038: D7415.diff
Wed, Aug 9, 7:59 PM
F11021371: D7415.diff
Mon, Aug 7, 1:54 PM
F10964756: D7415.id17774.diff
Wed, Jul 19, 2:06 PM
F10963063: D7415.diff
Wed, Jul 19, 1:33 AM
View All 19 Files
Subscribers
JoshStrobl
maverick1

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R4838:8177e5e629fa: Initial inclution of flask-httpauth, needed for onionshare
Summary

The initial inclution of flask-httpauth

Test Plan
  • Run new version of onionshare with this.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Jacalz created this revision.Oct 16 2019, 5:17 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptOct 16 2019, 5:17 PM
Jacalz requested review of this revision.Oct 16 2019, 5:17 PM
Jacalz added a child revision: D7416: Update onionshare to 2.2.
maverick1 added a subscriber: maverick1.Oct 17 2019, 4:42 AM
maverick1 added inline comments.
package.yml
12

You don't need flask as a build dep here, since you are not running any checks. Also, you might want to run %python3_test for checks.

JoshStrobl requested changes to this revision.Oct 17 2019, 9:35 AM
JoshStrobl added a subscriber: JoshStrobl.

Marking for changes per feedback from maverick.

This revision now requires changes to proceed.Oct 17 2019, 9:35 AM
Jacalz updated this revision to Diff 17828.Oct 17 2019, 5:56 PM
  • Add tests for the package
JoshStrobl accepted this revision.Oct 17 2019, 6:20 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 17 2019, 6:20 PM
Closed by commit R4838:8177e5e629fa: Initial inclution of flask-httpauth, needed for onionshare (authored by Jacalz, committed by JoshStrobl). · Explain WhyOct 17 2019, 6:21 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R4838:8177e5e629fa: Initial inclution of flask-httpauth, needed for onionshare.

Revision Contents
Changeset List

PathSize
4 lines
1 line
18 lines
41 lines

Diff 17774

View Options

MAINTAINERS.md

Loading...
View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.