Page MenuHomeSolus

Initial inclution of flask-httpauth, needed for onionshare

Authored by Jacalz on Oct 16 2019, 5:17 PM.



The initial inclution of flask-httpauth

Test Plan
  • Run new version of onionshare with this.

Diff Detail

R4838 flask-httpauth
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Oct 16 2019, 5:17 PM
Jacalz requested review of this revision.Oct 16 2019, 5:17 PM
Jacalz added a child revision: D7416: Update onionshare to 2.2.
maverick1 added inline comments.

You don't need flask as a build dep here, since you are not running any checks. Also, you might want to run %python3_test for checks.

JoshStrobl requested changes to this revision.Oct 17 2019, 9:35 AM
JoshStrobl added a subscriber: JoshStrobl.

Marking for changes per feedback from maverick.

This revision now requires changes to proceed.Oct 17 2019, 9:35 AM
Jacalz updated this revision to Diff 17828.Oct 17 2019, 5:56 PM
  • Add tests for the package
JoshStrobl accepted this revision.Oct 17 2019, 6:20 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 17 2019, 6:20 PM
This revision was automatically updated to reflect the committed changes.