Page MenuHomeSolus

Update x42-plugins to 20191013
ClosedPublic

Authored by Jacalz on Oct 15 2019, 6:19 PM.

Details

Summary

No changelog provided by upstream from what I can tell.

Packaging Changes:

  • Update against zita-convolver changes.
  • Rebuild against modern build toolchain and updated lv2.
Test Plan
  • Open up a couple plugins in Carla to verify that they work.

Diff Detail

Repository
R4547 x42-plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Oct 15 2019, 6:19 PM
Jacalz requested review of this revision.Oct 15 2019, 6:19 PM
JoshStrobl requested changes to this revision.Thu, Oct 17, 9:46 AM
JoshStrobl added a subscriber: JoshStrobl.

Stupid question but Phabricator changed how whitespace is rendered in diffs, could you validate that the indentation changes retain the usages of spaces please?

package.yml
12–23

Not needed, you have pkgconfig(pango)

15

Not needed, is a dep of glu

This revision now requires changes to proceed.Thu, Oct 17, 9:46 AM
Jacalz updated this revision to Diff 17831.Thu, Oct 17, 6:15 PM
  • Clean up the build deps to sort out review comments

Stupid question but Phabricator changed how whitespace is rendered in diffs, could you validate that the indentation changes retain the usages of spaces please?

They seem to be retained as far as I can see :)

JoshStrobl accepted this revision.Thu, Oct 17, 6:19 PM

Thanks, patch looks good to me!

This revision is now accepted and ready to land.Thu, Oct 17, 6:19 PM
This revision was automatically updated to reflect the committed changes.