upgrade klayout to 0.26
ClosedPublic
Actions

Authored by hashhsah on Oct 13 2019, 5:36 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R3851:ed888e11563a: upgrade klayout to 0.26

Summary

upgrade klayout to 0.26

This is a major release. New features include a standalone python module, hierarchical DRC, and netlist extraction for Antenna and LVS.

Complete changelog can be found here.

Test Plan

As before, open a few GDS files (kB to GB in size) and browse the layout. Open Help->About and check it ruby/python bindings are present in the `Build options'.

Open a few GDS files (kB to GB in size) and browse the layout.
Open Help->About and check it ruby/python bindings are present in the Build options and ~20 .so files are present in Binary Extensions.
Start python3, import klayout and pya modules.

Diff Detail

Repository

R3851 klayout

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hashhsah requested review of this revision.Oct 13 2019, 5:36 AM

hashhsah created this revision.

hang on a min, i realize that because i did git rebase, i need to rebuild to update the release number and update the diff.

increment release number

JoshStrobl edited the summary of this revision. (Show Details)Oct 17 2019, 10:04 AM

JoshStrobl edited the test plan for this revision. (Show Details)

JoshStrobl requested changes to this revision.Oct 17 2019, 10:08 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
28	Eliminate cd line, use `-C build-release` for the make install (any reason you're not using `%make_install` as well?)
29	push bin-release
29–30	Combine install flags.
44	Combine install flags.
44–46	Combine install flags.
45	Combine install flags.
48	Combine install flags.
51	Combine install flags.
55	popd since you're moving out of bin-release dir

This revision now requires changes to proceed.Oct 17 2019, 10:08 AM

remove cd commands, use make -C instead.
combine arguments to install commands
not using %make_install because klayout's non-standard Makefile will install to DESTDIR with a flat layout. it's easier to install to bin_release/ first, then copy to $installdir with our own commands.