Page MenuHomeSolus

Update Hedgewars to 1.0.0
ClosedPublic

Authored by aleksvor on Oct 12 2019, 7:36 AM.

Details

Summary

Summarized changelog:

  • Campaigns now respect your team identity instead of overwriting it.
  • Single missions now support team selection and track your progress.
  • Challenges track the team's highscores.
  • Hand-drawn maps can now be scaled with slider.
  • Quick games are more random.
  • Homing bee can be used as secondary ammo.
  • Can change hedgehog order in The Specialists.
  • Turn transition is less hectic
  • Various small HUD improvements
  • Fix wrong key names being displayed in key selection

Full changelog.

Test Plan

Played a match against bots.

Diff Detail

Repository
R1398 hedgewars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Oct 12 2019, 7:36 AM
aleksvor requested review of this revision.Oct 12 2019, 7:36 AM
Jacalz added a subscriber: Jacalz.Oct 12 2019, 10:21 AM
Jacalz added inline comments.
package.yml
26

You can remove the singe dot, it's not needed.

32

This can be changed to %make test to simplify it a bit.

Jacalz added inline comments.Oct 12 2019, 10:22 AM
package.yml
22

The pkgconfig builddeps should be ordered alphabetically above fpc.

aleksvor added inline comments.Oct 12 2019, 12:16 PM
package.yml
22

As Josh pointed out in D6751 to me, the sorting must be case-sensitive (A-Z, then a-z).

26

It's not needed for %cmake_ninja, but needed for regular %cmake. Without the dot you'll get warning:

CMake Warning:
No source or binary directory provided. Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.

That's because our regular cmake macro doesn't specify build directory and builds everything in-source by default. This is not the case for cmake_ninja because it builds in solusBuildDir directory and specifies this in the macro expansion (source).
While for now writing %cmake without specifying directory isn't critical, according to warning it can cause problems with future CMake releases.

32

This is usually used when autotests can fail in normal situations for some reason, so this ensures that test error won't be fatal for entire build process. I don't know why this was added here, so I prefer to leave it as it is.

JoshStrobl accepted this revision.Thu, Oct 17, 10:16 AM
JoshStrobl added a subscriber: JoshStrobl.

Leave patch review to Core Team and Global Maintainers, thank you. The patch is fine.

This revision is now accepted and ready to land.Thu, Oct 17, 10:16 AM
This revision was automatically updated to reflect the committed changes.