Page MenuHomeSolus

Initial inclusion of jack2, fixes T3167
Needs ReviewPublic

Authored by Jacalz on Thu, Oct 3, 5:46 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Maniphest Tasks
T3167: JACK2
Summary

This is the first inclusion of jack-audio-connection-kit version two. We have a fully working JACK2 with 64/32bit mixed multilib support. It just works.™ It is not aimed at replacing jack1 but to be a suplementary addition for jack users, because they both have their upsides and downsides at the moment.

Depends on D7121 and D7302
Fixes T3167

Test Plan
  • Tested midi input to and sound output from qsynth.
  • Verified that we have working sound output from ardour and lmms (lmms seems to work way better with jack2 than jack1 from inital testing).
  • Checked version using jackd -v.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacalz created this revision.Thu, Oct 3, 5:46 PM
Jacalz requested review of this revision.Thu, Oct 3, 5:46 PM

Changes requested in the old revision have been applied and I'm adding you all to subscribers here. I am sorry that Arcanist did this to us but it should be all fine now :)

Jacalz added a comment.Sat, Oct 5, 9:06 AM

It looks like eopkg doesn't handle multiple drop in replacement packages very well. Would be good if we could wire in some small support in to it to tell that jack-audio-connection-kit and jack2 are drop in replacements for each other. Right now if you have jack2 installed it will want to replace it with jack-audio-connection-kit when updating a package linked to jack1. Jack1 and jack2 both have their weaknesses and strengths so deprecating jack1 should NOT be an option at the moment.

Any thoughts @DataDrake and @JoshStrobl ?

Jacalz updated this revision to Diff 17608.Mon, Oct 7, 7:27 PM
  • Update to 1.9.13 (the fancy new meta-data api had to be turned off to build it)
Jacalz updated this revision to Diff 17684.EditedSat, Oct 12, 12:34 PM
  • Drop 32-bit mixed mode for now. (db5-32bit-devel seems to be broken ish?)
  • Enable metadata support properly now.
Jacalz updated this revision to Diff 17685.Sat, Oct 12, 12:35 PM
  • Remove 32bit leftovers
Jacalz updated this revision to Diff 17686.Sat, Oct 12, 12:36 PM
  • Remove the last 32bit leftover. (I promise this is the last one...)
Jacalz updated this revision to Diff 17715.Sun, Oct 13, 10:13 AM
  • Update homepage to https (website update happened yesterday).
Jacalz updated this revision to Diff 17731.Sun, Oct 13, 10:35 AM
  • Got 32bit build working with metadata support (I think so at least).
Jacalz updated this revision to Diff 17779.Wed, Oct 16, 5:34 PM
  • Add patch from falkTX to get the mixed 64/32bit mode to work in 1.9.13
Jacalz updated this revision to Diff 17839.Thu, Oct 17, 6:30 PM
  • Switch from replaces to using conflicts
JoshStrobl retitled this revision from Initial inclution of jack2, fixes T3167 to Initial inclusion of jack2, fixes T3167.Thu, Oct 17, 6:31 PM