Page MenuHomeSolus

Make jack1 replace jack2 when installed afterwards
AcceptedPublic

Authored by Jacalz on Wed, Oct 2, 7:10 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

If a user wants to switch to jack1, jack2 should be replaced by jack1.

Test Plan
  • Made sure that it removed jack2 like expected.

Diff Detail

Repository
R1495 jack-audio-connection-kit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacalz created this revision.Wed, Oct 2, 7:10 PM
Jacalz requested review of this revision.Wed, Oct 2, 7:10 PM
Jacalz edited the summary of this revision. (Show Details)Wed, Oct 2, 7:11 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz updated this revision to Diff 17520.Wed, Oct 2, 7:13 PM

Slight update to the summary

Jacalz updated this revision to Diff 17521.Wed, Oct 2, 7:16 PM
  • Drop professional to be more in line with jack2
Jacalz updated this revision to Diff 17716.Sun, Oct 13, 10:18 AM
  • Add homepage
JoshStrobl requested changes to this revision.Thu, Oct 17, 11:11 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
12

If a user wants to switch to jack1, jack2 should be replaced by jack1.

Using a replaces isn't how you would do this. conflicts would be.

This revision now requires changes to proceed.Thu, Oct 17, 11:11 AM
Jacalz updated this revision to Diff 17836.Thu, Oct 17, 6:26 PM
  • Switch from replaces to conflicts
JoshStrobl accepted this revision.Thu, Oct 17, 6:32 PM
JoshStrobl added a subscriber: DataDrake.

LGTM but still want @DataDrake to take a look at D7307

This revision is now accepted and ready to land.Thu, Oct 17, 6:32 PM