files/php.ini-production
969–971	Any reason this is being removed?
1121–1178	Is there any particular reason this is being removed? It's expected that MariaDB support will land eventually and it'd be easier to ensure PHP works OOTB with it if the configuration already existed in the INI file.

This revision now requires changes to proceed.May 10 2017, 2:05 PM

Hey Josh, I replied to your inline comments. As I said the MySQLi extension is missing as well as some other useful extensions. But I thought it would be "cleaner" if I first do the upgrade and afterwards change the build flags.

files/php.ini-production
969–971	Because it isn't present in the default php-production.ini shipped with PHP 7.1. I guess this is because the sqlite extension got replaced by the sqlite3 extension (see line 973).
1121–1178	As with the sqlite extension I guess it is not present anymore. Instead you should use the MySQLi driver (see line 1179) oder the MySQL native driver (mysqlnd). But at the moment our PHP version won't work with MySQL since you didn't pass the build flags for the MySQL extension. We should add --with-mysqli and/or --with-pdo-mysql to the package.yml.

JoshStrobl added inline comments.May 10 2017, 8:48 PM

files/php.ini-production
969–971	Gotcha. Works for me.
1121–1178	Right, as I stated,. we don't support MySQL / MariaDB yet. But I'd rather we keep these configs in for when we do enable it. Saves us having to add it back in.

der_eismann added inline comments.May 11 2017, 7:48 AM

files/php.ini-production
1121–1178	I guess you misunderstood me. There is no "MySQL" extension anymore, it's old and obsolete, so this part of the config is irrelevant - the same as with sqlite. The new and only extensions that should be used is "MySQLi" which still has a usable config located in line 1179 (right below our comments) and "mysqlnd" which can also be found a little down. (See here)