Page MenuHomeSolus

Update smtube to 19.6.0
ClosedPublic

Authored by Staudey on Sun, Sep 29, 3:23 PM.

Details

Summary

Update smtube to 19.6.0

Fixes the Youtube code

Fixes T8370

Note: Doesn't seem to work in conjunction with VLC and mpv, but works fine with SMPlayer and mpv+youtube-dl options

Test Plan

Played several Youtube videos

Diff Detail

Repository
R2918 smtube
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Sun, Sep 29, 3:23 PM
Staudey requested review of this revision.Sun, Sep 29, 3:23 PM
algent added a subscriber: algent.Sun, Sep 29, 3:33 PM

Videos from tonvid.com are opened by default with VLC.

Videos from tonvid.com are opened by default with VLC.

Well, only if you haven't installed SMPlayer. In any case you can change the order of which player to use in the Settings.
I've played with the thought of adding SMPlayer as a rundep, because it works and is listed as first option by default, but then again it isn't technically required for smtube to function.

Jacalz added a subscriber: Jacalz.Mon, Sep 30, 5:44 AM
Jacalz added inline comments.
package.yml
5–6

Should be GPL-2.0-or-later

Staudey updated this revision to Diff 17439.Mon, Sep 30, 4:51 PM

Correct license term

Staudey marked an inline comment as done.Mon, Sep 30, 4:51 PM
Staudey added inline comments.
package.yml
5–6

Thanks, you're right. Fixed it.

JoshStrobl accepted this revision.Tue, Oct 1, 12:24 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Oct 1, 12:24 PM
This revision was automatically updated to reflect the committed changes.