Page MenuHomeSolus

initial package of python-llvmlite
ClosedPublic

Authored by hashhsah on Sep 27 2019, 4:43 PM.

Details

Summary

This is a dependency of D7257

Test Plan

The check step all passed.
Build, install numba and test from numba.

Diff Detail

Repository
R4827 python-llvmlite
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hashhsah created this revision.Sep 27 2019, 4:43 PM
hashhsah requested review of this revision.Sep 27 2019, 4:43 PM

This isn't how stacks work, it should be a dep of the diff not the task.

hashhsah edited the summary of this revision. (Show Details)Oct 1 2019, 12:48 PM
JoshStrobl requested changes to this revision.Oct 1 2019, 1:01 PM

Otherwise LGTM.

package.yml
11

If we're gonna be pedantic about the description, there should be a : after approach since it is indicating a list. Also not entirely sure how much overkill the indentation of the list items are, ruamel.yaml doesn't exactly provide the most consistent behavior.

This revision now requires changes to proceed.Oct 1 2019, 1:01 PM
hashhsah updated this revision to Diff 17484.Oct 1 2019, 1:28 PM

revised package description.

I removed the : in fear of yaml parser mis-behavior, because the syntax highlighter in vim did not parse it correctly.
So I tried the ruamel parser, and it seems to work nicely.

>>> x = ruamel.yaml.safe_load('''
... description: |
...     llvmlite is a project originally tailored for Numba's needs, using the following approach:
...         - small C wrapper around the parts of the LLVM C++ API we need that are not already exposed by the LLVM C API.
...         - ctypes Python wrapper around the C API.
...         - pure Python implementation of the subset of the LLVM IR builder that we need for Numba.
... ''')
>>> 
>>> print(x['description'])
llvmlite is a project originally tailored for Numba's needs, using the following approach:
    - small C wrapper around the parts of the LLVM C++ API we need that are not already exposed by the LLVM C API.
    - ctypes Python wrapper around the C API.
    - pure Python implementation of the subset of the LLVM IR builder that we need for Numba.
JoshStrobl accepted this revision.Oct 1 2019, 1:31 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 1 2019, 1:31 PM

Given this is only going to be used for python-numba, which is python3, we can nuke the python2 site packages + support.

hashhsah updated this revision to Diff 17501.Oct 1 2019, 4:05 PM

remove python2 support

JoshStrobl accepted this revision.Oct 1 2019, 4:11 PM

LGTM, thanks!

This revision was automatically updated to reflect the committed changes.

Failed to compile, guessing sha256sum changed. I'll sort it after I get back from the store.