Differential D7239

Update peek to 1.4.0
ClosedPublic
Actions

Authored by Jacalz on Sep 24 2019, 5:51 PM.

Tags

None

Referenced Files

	F11073773: D7239.diff
	Sat, Aug 12, 5:00 AM

	F11016070: D7239.diff
	Sat, Aug 5, 4:28 PM

	F10996641: D7239.id17373.diff
	Wed, Jul 26, 8:59 PM

	F10976793: D7239.diff
	Sat, Jul 22, 11:59 AM

	F10893685: D7239.id17510.diff
	Jul 1 2023, 12:35 AM

	F10891329: D7239.diff
	Jun 29 2023, 12:42 AM

	F10878386: D7239.id17351.diff
	Jun 21 2023, 8:25 AM

	F10877718: D7239.id17510.diff
	Jun 20 2023, 10:13 PM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2313:53a26728bbf1: Update peek to 1.4.0

Summary

Summarized Changelog:

Move app menu into application Window.
New application icon following new GNOME icon guidelines.
Set window type hint to UTILITY (ensures window gets opened as floating on tiling window managers).
Show shortcut hint in main window.
Added Recorder, Video and AudioVideo to desktop files categories.
Improved the error message shown on GNOME Shell recording issues.
Provide more details in error reports.
Updated translations for Basque, Chinese (simplified), Chinese (traditional), Czech, Dutch, Esperanto, French, German, Italian, Japanese, Lithuanian, Norwegian Bokmål, Polish, Portuguese (Brazil), Portuguese (Portugal), Russian, Serbian, Spanish, Swedish, Turkish, Ukrainian.
New translations for Japanese and Turkish.
Autogenerate po/LINGUAS.
Fixed building with Vala 0.46.1.

Test Plan

Recorded vidoes with regular GIF, APNG, WEBM, MP4 and gifski GIF.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Jacalz created this revision.Sep 24 2019, 5:51 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 24 2019, 5:51 PM

Jacalz requested review of this revision.Sep 24 2019, 5:51 PM

Will make sure to get this updated against new vala and the new peek rebuild tomorrow.

In D7239#114812, @Jacalz wrote:

Will make sure to get this updated against new vala and the new peek rebuild tomorrow.

Thanks, I'll go ahead and mark this as request changes pending rebasing.

This revision now requires changes to proceed.Sep 26 2019, 11:26 AM

Update against vala 46.1 (seems to make the tests work again yay)

Jacalz mentioned this in T8336: Peek crashing when saving gif.Sep 30 2019, 6:50 PM

JoshStrobl added inline comments.Oct 1 2019, 12:03 PM

package.yml
23	You didn't delete the patch though.

Remove patch and verify rebuilding against vala 46.2

LGTM, thanks!

This revision is now accepted and ready to land.Oct 1 2019, 6:28 PM

Closed by commit R2313:53a26728bbf1: Update peek to 1.4.0 (authored by Jacalz, committed by JoshStrobl). · Explain WhyOct 1 2019, 6:29 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R2313:53a26728bbf1: Update peek to 1.4.0.

Revision Contents
Changeset List

Path

Size

10 lines

pspec_x86_64.xml

14 lines

Diff 17373

package.yml

Loading...

pspec_x86_64.xml

Loading...