Page MenuHomeSolus

Update rustup to 1.19.0
ClosedPublic

Authored by josephscade on Sep 21 2019, 1:15 PM.
Tags
None
Referenced Files
F11047312: D7218.id17499.diff
Thu, Aug 10, 3:12 PM
F11047311: D7218.id.diff
Thu, Aug 10, 3:12 PM
F11047310: D7218.id17318.diff
Thu, Aug 10, 3:12 PM
F11047309: D7218.id17497.diff
Thu, Aug 10, 3:12 PM
F11047308: D7218.id17382.diff
Thu, Aug 10, 3:12 PM
F11033069: D7218.diff
Wed, Aug 9, 3:10 PM
F10972646: D7218.id.diff
Fri, Jul 21, 3:08 PM
F10848513: D7218.id17499.diff
Jun 11 2023, 3:32 PM

Details

Summary

Changed:

  • Fix race condition with some virus scanners
  • UI improvements for race condition fix
  • Improve home mismatch explanation
  • Enable fully threaded IO for installs
  • Improve look of rustup homepage
  • Improve messaging if shell profile cannot be updated
  • Improve messaging around directory names during install
  • Disregard unavailable targets
  • No longer provide non-panic backtraces by default

Added:

  • Add support for rustup target add all
  • Add rustup show home
  • Add NetBSD target to CI
  • Add x86_64 musl to CI
Test Plan

Install the stable rust toolchain by running rustup install stable as a non-root user.

Diff Detail

Repository
R4626 rustup
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Your link to the changelog is wrong: it points to the HEAD commit, whereas it should point to the 1.19.0 tag. Regardless, the changelog is small enough and easy to copy and paste to be directly included in the summary.

Also, can we address T8200? I'm talking to Core Team specifically.

josephscade edited the test plan for this revision. (Show Details)

Hello,
You're right about the changelog, it is fixed now.
Thank you for your remark about the changelog link. I will apply this rule for next releases (where changelog is too long and so on).

JoshStrobl added a subscriber: JoshStrobl.

Your link to the changelog is wrong: it points to the HEAD commit, whereas it should point to the 1.19.0 tag. Regardless, the changelog is small enough and easy to copy and paste to be directly included in the summary.

Also, can we address T8200? I'm talking to Core Team specifically.

If we're going to add these symlinks then yes, we'll need to add the conflicts: rust so you can't have them both installed at the same time. The solution will be sufficient since at that point, there is no middleground or being able to have both.

The patch itself looks good but I'll mark it as request changes pending resolution of the task / adding the symlinks + conflicts key/val.

This revision now requires changes to proceed.Sep 26 2019, 11:52 AM

Add rust as a conflicting package and add appropriate symlinks.

The symlink code comes from the Archlinux package. Feel free to tell me if it does not meet Solus' guidelines.

package.yml
16

Sorry, it occurred to me that we need this to conflict with cargo as well, so it should be a list like builddeps is.

25

I could be blind but I'm not seeing us shipping cargo-fmt, cargo-clippy, and clippy-driver anywhere. Do those have any value to us and if so, why aren't they in the rust or cargo packages?

Furthermore, we also have a rust-gdbgui in the rust package, would that be a binary provided by the rustup tooling and available via rustup?

package.yml
16

I'm working on it, as well as your other comment. I'll send the patches in a few minutes (time to build rustup and test it.

25

Thanks for your comment. You're right, I'm working on it.

Add the conflicting with rust and cargo, changes the symlink created.

This revision is now accepted and ready to land.Oct 1 2019, 3:36 PM
This revision was automatically updated to reflect the committed changes.