Update rustup to 1.19.0
ClosedPublic
Actions

Authored by josephscade on Sep 21 2019, 1:15 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R4626:17b1d3c46e27: Update rustup to 1.19.0

Summary

Changed:

Fix race condition with some virus scanners
UI improvements for race condition fix
Improve home mismatch explanation
Enable fully threaded IO for installs
Improve look of rustup homepage
Improve messaging if shell profile cannot be updated
Improve messaging around directory names during install
Disregard unavailable targets
No longer provide non-panic backtraces by default

Added:

Add support for rustup target add all
Add rustup show home
Add NetBSD target to CI
Add x86_64 musl to CI

Test Plan

Install the stable rust toolchain by running rustup install stable as a non-root user.

Diff Detail

Repository

R4626 rustup

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

josephscade created this revision.Sep 21 2019, 1:15 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 21 2019, 1:15 PM

josephscade requested review of this revision.Sep 21 2019, 1:15 PM

Your link to the changelog is wrong: it points to the HEAD commit, whereas it should point to the 1.19.0 tag. Regardless, the changelog is small enough and easy to copy and paste to be directly included in the summary.

Also, can we address T8200? I'm talking to Core Team specifically.

Hello,
You're right about the changelog, it is fixed now.
Thank you for your remark about the changelog link. I will apply this rule for next releases (where changelog is too long and so on).

In D7218#114654, @livingsilver94 wrote:

Your link to the changelog is wrong: it points to the HEAD commit, whereas it should point to the 1.19.0 tag. Regardless, the changelog is small enough and easy to copy and paste to be directly included in the summary.

Also, can we address T8200? I'm talking to Core Team specifically.

If we're going to add these symlinks then yes, we'll need to add the conflicts: rust so you can't have them both installed at the same time. The solution will be sufficient since at that point, there is no middleground or being able to have both.

The patch itself looks good but I'll mark it as request changes pending resolution of the task / adding the symlinks + conflicts key/val.

This revision now requires changes to proceed.Sep 26 2019, 11:52 AM

Add rust as a conflicting package and add appropriate symlinks.

The symlink code comes from the Archlinux package. Feel free to tell me if it does not meet Solus' guidelines.

JoshStrobl added inline comments.Oct 1 2019, 12:07 PM

package.yml
16	Sorry, it occurred to me that we need this to conflict with cargo as well, so it should be a list like builddeps is.
22	I could be blind but I'm not seeing us shipping cargo-fmt, cargo-clippy, and clippy-driver anywhere. Do those have any value to us and if so, why aren't they in the rust or cargo packages? Furthermore, we also have a rust-gdbgui in the rust package, would that be a binary provided by the rustup tooling and available via rustup?

josephscade added inline comments.Oct 1 2019, 3:17 PM

package.yml
16	I'm working on it, as well as your other comment. I'll send the patches in a few minutes (time to build `rustup` and test it.
22	Thanks for your comment. You're right, I'm working on it.