Page MenuHomeSolus

Initial inclusion of tealdeer
ClosedPublic

Authored by abdulocracy on Sep 10 2019, 4:58 PM.

Details

Summary

Initial inclusion of tealdeer, fixes T8180. Based on @Jacek's initial diff.

Test Plan

Read a command's tldr page (i.e. tldr ssh). Test tab completion for Bash, fish and Zsh.

Diff Detail

Repository
R4814 tealdeer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

abdulocracy created this revision.Sep 10 2019, 4:58 PM
abdulocracy requested review of this revision.Sep 10 2019, 4:58 PM
Jacek added a comment.Sep 10 2019, 5:27 PM

You didn't include a feature introduced in 1.2, which is fish autocompletion. Here is mine package.yml{F5130896}

abdulocracy updated this revision to Diff 17128.EditedSep 10 2019, 9:00 PM

Add fish completion and change descriptions.

Thanks @Jacek. :-)

abdulocracy edited the test plan for this revision. (Show Details)Sep 10 2019, 9:01 PM
Jacek added a comment.Sep 11 2019, 8:41 AM

I have tested it for a few weeks, this is ready to be accepted!

Macro justdoit:

(Oh, you can add memes on phabricator, good to know)

JoshStrobl requested changes to this revision.Sep 12 2019, 7:37 PM
JoshStrobl added a subscriber: JoshStrobl.

ZSH person here: I don't want to be an inferior user for a CLI of a tool I'll never use (joking). Let's get it added from this file in master to /usr/share/zsh/site-functions/_tealdeer. Chuck it in files/ until the next tealdeer release.

This revision now requires changes to proceed.Sep 12 2019, 7:37 PM
abdulocracy updated this revision to Diff 17186.EditedSep 14 2019, 5:55 PM

Add zsh completions.

Edit: So that didn't work, I accidentally deleted the initial repo and can't find a way to add the new files, any help would be greatly appreciated. :)

abdulocracy updated this revision to Diff 17190.EditedSep 14 2019, 8:28 PM

Hopefully add the files this time.

Edit: It worked! Thanks @DataDrake (on IRC)!

abdulocracy edited the test plan for this revision. (Show Details)Sep 14 2019, 8:39 PM
JoshStrobl requested changes to this revision.Sep 17 2019, 10:35 AM

Your branch isn't correct, you should be submitted against a new repo, on a master branch.

This revision now requires changes to proceed.Sep 17 2019, 10:35 AM

Like this? :)

JoshStrobl accepted this revision.Sep 20 2019, 5:50 AM

Yep, looks it, let's get this landed!

This revision is now accepted and ready to land.Sep 20 2019, 5:50 AM
This revision was automatically updated to reflect the committed changes.