Differential D7132

Initial commit of geckodriver
ClosedPublic
Actions

Authored by maverick1 on Sep 10 2019, 3:50 AM.

Tags

None

Referenced Files

	F11052362: D7132.id17283.diff
	Thu, Aug 10, 9:18 PM

	F11052361: D7132.id17099.diff
	Thu, Aug 10, 9:18 PM

	F11052360: D7132.id.diff
	Thu, Aug 10, 9:18 PM

	F11052359: D7132.id17220.diff
	Thu, Aug 10, 9:18 PM

	F11037050: D7132.diff
	Wed, Aug 9, 8:01 PM

	F10985890: D7132.diff
	Sun, Jul 23, 11:14 PM

	F10967274: D7132.id17283.diff
	Thu, Jul 20, 8:40 AM

	F10967273: D7132.id17220.diff
	Thu, Jul 20, 8:40 AM

View All 20 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R4815:179ebafdd588: Initial commit of geckodriver

Summary

Initial commit of geckodriver for selenium

Test Plan

Started automated testing through firefox using selenium

Diff Detail

Repository

R4815 geckodriver

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

maverick1 created this revision.Sep 10 2019, 3:50 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 10 2019, 3:50 AM

maverick1 requested review of this revision.Sep 10 2019, 3:50 AM

maverick1 added a child revision: D7131: Initial inclusion of python-selenium.Sep 10 2019, 3:52 AM

Apologies for the delay, let's get this updated to 0.25.0. Patch looks good otherwise ?

This revision now requires changes to proceed.Sep 17 2019, 10:52 AM

In D7132#113818, @JoshStrobl wrote:

Apologies for the delay, let's get this updated to 0.25.0. Patch looks good otherwise ?

Why are my other patches not being accepted? If there is anything wrong with them then please tell me, I will do my best to remove the errors.

Bump to 0.25.0

In D7132#113856, @maverick1 wrote:

In D7132#113818, @JoshStrobl wrote:

Apologies for the delay, let's get this updated to 0.25.0. Patch looks good otherwise ?

Why are my other patches not being accepted? If there is anything wrong with them then please tell me, I will do my best to remove the errors.

Because I only have a limited amount of time in each day to review things and prioritize differently than what you may agree with. Like everyone else, I work on Solus on a purely voluntary basis.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 20 2019, 5:52 AM

Closed by commit R4815:179ebafdd588: Initial commit of geckodriver (authored by maverick1, committed by JoshStrobl). · Explain WhySep 20 2019, 5:53 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4815:179ebafdd588: Initial commit of geckodriver.

Revision Contents
Changeset List

Path

Size

1 line

7 lines

19 lines

pspec_x86_64.xml

38 lines

Diff 17283

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...