Page MenuHomeSolus

Initial commit of geckodriver
ClosedPublic

Authored by maverick1 on Sep 10 2019, 3:50 AM.

Details

Summary

Initial commit of geckodriver for selenium

Test Plan

Started automated testing through firefox using selenium

Diff Detail

Repository
R4815 geckodriver
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maverick1 created this revision.Sep 10 2019, 3:50 AM
maverick1 requested review of this revision.Sep 10 2019, 3:50 AM
JoshStrobl requested changes to this revision.Sep 17 2019, 10:52 AM
JoshStrobl added a subscriber: JoshStrobl.

Apologies for the delay, let's get this updated to 0.25.0. Patch looks good otherwise ๐Ÿ‘

This revision now requires changes to proceed.Sep 17 2019, 10:52 AM

Apologies for the delay, let's get this updated to 0.25.0. Patch looks good otherwise ๐Ÿ‘

Why are my other patches not being accepted? If there is anything wrong with them then please tell me, I will do my best to remove the errors.

maverick1 updated this revision to Diff 17220.Sep 17 2019, 1:57 PM

Bump to 0.25.0

Apologies for the delay, let's get this updated to 0.25.0. Patch looks good otherwise ๐Ÿ‘

Why are my other patches not being accepted? If there is anything wrong with them then please tell me, I will do my best to remove the errors.

Because I only have a limited amount of time in each day to review things and prioritize differently than what you may agree with. Like everyone else, I work on Solus on a purely voluntary basis.

JoshStrobl accepted this revision.Sep 20 2019, 5:52 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 20 2019, 5:52 AM
This revision was automatically updated to reflect the committed changes.