Page MenuHomeSolus

Initial commit of drawing
ClosedPublic

Authored by Staudey on Sun, Sep 8, 8:29 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T7871: Drawing
Commits
R4813:a9ad9e56c5a7: Initial commit of drawing
Summary

Initial inclusion of drawing

Fixes T7871

Test Plan

Been using it for some months now for simple image manipulation (cropping, drawing rectangles to mark things). Just now ran trough all the available tools again and tested that they worked as expected

Diff Detail

Repository
R4813 drawing
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Sun, Sep 8, 8:29 PM
Staudey requested review of this revision.Sun, Sep 8, 8:29 PM
Staudey updated this revision to Diff 17072.Sun, Sep 8, 8:52 PM

Add libgtk-3 rundep and fix an oversight

JoshStrobl requested changes to this revision.Tue, Sep 10, 10:14 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

It also needs python3-gobject and python3-cairo. Worth checking for more from https://github.com/maoschanz/drawing/tree/master/src

This revision now requires changes to proceed.Tue, Sep 10, 10:14 AM
Staudey updated this revision to Diff 17122.Tue, Sep 10, 6:00 PM

Add python dependencies

Staudey marked an inline comment as done.Tue, Sep 10, 6:02 PM
Staudey added inline comments.
package.yml
13

Thanks! I've looked through the imports and I think with the two packages you've suggested we should have everything covered.
Guess I should create a testing VM for ALL DEs, not just Budgie, so I can catch things like this.

JoshStrobl accepted this revision.Tue, Sep 10, 6:08 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Sep 10, 6:08 PM
This revision was automatically updated to reflect the committed changes.