Page MenuHomeSolus

Update slop to 7.3.49
ClosedPublic

Authored by euoar on Jul 25 2017, 2:48 PM.

Details

Summary

Changes since 6.3.38:

  • GLEW is back, Nvidia preload segfault is eliminated
  • Slop now no longer selects shadows around windows in Mutter (the Gnome window manager). Gone is the annoying arbitrary padding around Gnome windows.
Test Plan
  • Installed and run the tests as on the README file. All displaying ok

Diff Detail

Repository
R3387 slop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

euoar created this revision.Jul 25 2017, 2:48 PM
euoar updated this revision to Diff 1539.Jul 25 2017, 2:54 PM

Reorder dependencies.

euoar updated this revision to Diff 1991.Aug 29 2017, 7:48 PM

Updating the revision, as a new version has been released since the initial revision was sent.

euoar retitled this revision from Update slop to 6.3.47 to Update slop to 6.3.48.Aug 29 2017, 7:50 PM
euoar edited the summary of this revision. (Show Details)
joebonrichie requested changes to this revision.EditedSep 23 2017, 6:05 PM
joebonrichie added a subscriber: joebonrichie.

Outdated, the latest release is v7.3.49 . Sorry for the late review

This revision now requires changes to proceed.Sep 23 2017, 6:05 PM
euoar added a comment.Sep 23 2017, 6:23 PM

Thanks, I'll update and test the patch tomorrow

euoar updated this revision to Diff 2598.Sep 24 2017, 2:58 PM
euoar edited edge metadata.

Updated to the latest version of slop.

euoar retitled this revision from Update slop to 6.3.48 to Update slop to 7.3.49.Sep 24 2017, 2:59 PM
joebonrichie accepted this revision.Sep 25 2017, 11:24 AM

LGTM. I also tested the reverse dependencies maim and screenkey against the .so bump and everything seems to be working. Thanks for the patch :)

This revision is now accepted and ready to land.Sep 25 2017, 11:24 AM
This revision was automatically updated to reflect the committed changes.

In the future:

Installed and run the tests as on the README file. All displaying ok

Is not an acceptable test plan. People shouldn't have to dig into the README to figure out what the tests you ran were, they should be documented in the test plan.