Initial inclusion of jack2, fixes T3167
AbandonedPublic
Actions

Authored by Jacalz on Sep 8 2019, 8:09 AM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Maniphest Tasks

T3167: JACK2

Summary

This is the first inclusion of jack-audio-connection-kit version two. We have a fully working JACK2 with 64/32bit mixed multilib support. It just works.™

Test Plan

Tested midi input to and sound output from qsynth.
Verified that we have working sound output from ardour and lmms (lmms seems to work way better with jack2 than jack1 from inital testing).
Checked version using jackd -v.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Jacalz created this revision.Sep 8 2019, 8:09 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 8 2019, 8:09 AM

Jacalz requested review of this revision.Sep 8 2019, 8:09 AM

Jacalz edited the summary of this revision. (Show Details)Sep 8 2019, 8:12 AM

Jacalz retitled this revision from Initial version of jack2, fixes T3167 to Initial inclusion of jack2, fixes T3167.Sep 8 2019, 10:25 AM

I have almost gotten the 64/32bit mixed multilib compile to work. Just some issues left before it should be ready...

We have 64/32bit mixed multilib support working!

Jacalz edited the summary of this revision. (Show Details)Sep 8 2019, 3:56 PM

Jacalz edited the test plan for this revision. (Show Details)

Add maintainers file

Make sure that jack2 can run as realtime

I hope you don’t mind me takin on this task @DataDrake. I didn’t initially see that you were assigned and the news came to me afterwords, but I hope it’s okay :)

michaelkisiel added a subscriber: michaelkisiel.Sep 28 2019, 8:09 PM

@DataDrake please review this given you did all the jack + jack pam stuff.

Of course arcanist behaves badly and tells me that it can't parse empty diffs and I seem to be getting it just with this differential :(
I just had a little change to switch conflicts to replaces but I can't do that now. If this is accepted, could that be done afterwards?

Jacalz edited the summary of this revision. (Show Details)Oct 2 2019, 7:17 PM

Jacalz added a parent revision: D7302: Make jack1 replace jack2 when installed afterwards.

livingsilver94 added a subscriber: livingsilver94.Oct 2 2019, 10:22 PM

livingsilver94 added inline comments.

package.yml
35	`--libdir=/usr/lib64` coz I'm a nitpicker ?

kyrios123 added a subscriber: kyrios123.Oct 3 2019, 5:41 AM

kyrios123 added inline comments.

package.yml
35	`--libdir=%libdir%`. Especially since `emul32` is set to yes

livingsilver94 added inline comments.Oct 3 2019, 8:41 AM

package.yml
35	Good catch, but then I wonder what `--libdir32` is for...

Because pkgconfig is better than the package name.

package.yml
26	pkgconfig32(dbus-1)
27	pkgconfig32(libgcrypt)
29	pkgconfig32(liblzma)

Thanks for the reviews guys. I will need to open a new revision though, because Acanist has decided that this revision is empty and wont let me push updates to it any more :(
Should have a new one up shortly...

Jacalz edited the summary of this revision. (Show Details)Oct 3 2019, 5:45 PM