Page MenuHomeSolus

Initial commit of python-distro

Authored by kyrios123 on Sep 6 2019, 9:44 PM.



Inclusion of distro in the repository

Test Plan

Tested with certbot (new dependency)

Diff Detail

R4812 python-distro
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ma-renaud created this revision.Sep 6 2019, 9:44 PM
ma-renaud requested review of this revision.Sep 6 2019, 9:44 PM
kyrios123 requested changes to this revision.Sep 7 2019, 5:56 AM
kyrios123 added a subscriber: kyrios123.

Python 2 macros should be dropped, it's a dependency for conan which only requires python 3 (and python 2 support ends in 3 months anyway).


I am pretty sure the package would build without this.

This revision now requires changes to proceed.Sep 7 2019, 5:56 AM
kyrios123 commandeered this revision.Sep 8 2019, 1:25 PM
kyrios123 edited reviewers, added: ma-renaud; removed: kyrios123.

This is a new dependency for certbot and since I already reworked this patch, I'll submit it so you don't have to redo the work.
Thanks for the submission anyway, it's appreciated ! 😃

kyrios123 updated this revision to Diff 17065.Sep 8 2019, 1:28 PM
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 edited the test plan for this revision. (Show Details)
  • Fix package dependencies
  • Drop uneeded python2 stuffs
  • Enable unit tests
JoshStrobl accepted this revision.Sep 8 2019, 6:13 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 8 2019, 6:13 PM
This revision was automatically updated to reflect the committed changes.