Page MenuHomeSolus
Differential D7103

Initial commit of python-node-semver
ClosedPublic
Actions

Authored by ma-renaud on Sep 6 2019, 9:40 PM.
Tags
None
Referenced Files
F11066452: D7103.id17040.diff
Fri, Aug 11, 6:05 PM
F11066451: D7103.id.diff
Fri, Aug 11, 6:05 PM
F11066450: D7103.id17082.diff
Fri, Aug 11, 6:05 PM
F11066449: D7103.id17081.diff
Fri, Aug 11, 6:05 PM
F11066448: D7103.id18427.diff
Fri, Aug 11, 6:05 PM
F11066447: D7103.id18520.diff
Fri, Aug 11, 6:05 PM
F11047182: D7103.diff
Thu, Aug 10, 2:58 PM
F11038646: D7103.diff
Wed, Aug 9, 11:18 PM
View All 43 Files
Subscribers
DataDrake
kyrios123

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R4866:87935993fe1b: Initial commit of python-node-semver
Summary

Initial commit of python-node-semver.

Test Plan

Conan test plan must pass.

Diff Detail

Repository
R4866 python-node-semver
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ma-renaud created this revision.Sep 6 2019, 9:40 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptSep 6 2019, 9:40 PM
ma-renaud requested review of this revision.Sep 6 2019, 9:40 PM
ma-renaud added a child revision: D7102: Initial commit of Conan..Sep 6 2019, 9:52 PM
kyrios123 mentioned this in D7102: Initial commit of Conan..Sep 7 2019, 5:41 AM
kyrios123 added a subscriber: kyrios123.Sep 7 2019, 5:45 AM
kyrios123 added inline comments.
package.yml
14

This is for python2 only, you can remove it.

kyrios123 added a comment.Sep 7 2019, 5:47 AM

Also this is a dependency for conan which is python3 so don't build python2 in the dependencies !

kyrios123 requested changes to this revision.Sep 7 2019, 5:49 AM
This revision now requires changes to proceed.Sep 7 2019, 5:49 AM
ma-renaud updated this revision to Diff 17081.Sep 9 2019, 12:55 PM

Removed python-setuptools.

ma-renaud updated this revision to Diff 17082.Sep 9 2019, 1:00 PM

Remove build for python2.

DataDrake accepted this revision.Nov 18 2019, 5:25 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

DataDrake requested changes to this revision.Nov 18 2019, 6:16 AM

Missing a Makefile.

This revision now requires changes to proceed.Nov 18 2019, 6:16 AM
ma-renaud updated this revision to Diff 18427.Nov 20 2019, 1:48 PM

Makefile added.

DataDrake accepted this revision.Nov 26 2019, 12:40 AM
DataDrake removed a reviewer: kyrios123.

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 26 2019, 12:40 AM
Closed by commit R4866:87935993fe1b: Initial commit of python-node-semver (authored by ma-renaud, committed by DataDrake). · Explain WhyNov 26 2019, 12:42 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4866:87935993fe1b: Initial commit of python-node-semver.

Revision Contents
Changeset List

PathSize
1 line
16 lines
81 lines

Diff 18520

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.