Page MenuHomeSolus

Initial commit of python-node-semver
ClosedPublic

Authored by ma-renaud on Sep 6 2019, 9:40 PM.

Details

Summary

Initial commit of python-node-semver.

Test Plan

Conan test plan must pass.

Diff Detail

Repository
R4866 python-node-semver
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ma-renaud created this revision.Sep 6 2019, 9:40 PM
ma-renaud requested review of this revision.Sep 6 2019, 9:40 PM
kyrios123 added inline comments.
package.yml
14

This is for python2 only, you can remove it.

Also this is a dependency for conan which is python3 so don't build python2 in the dependencies !

kyrios123 requested changes to this revision.Sep 7 2019, 5:49 AM
This revision now requires changes to proceed.Sep 7 2019, 5:49 AM
ma-renaud updated this revision to Diff 17081.Sep 9 2019, 12:55 PM

Removed python-setuptools.

ma-renaud updated this revision to Diff 17082.Sep 9 2019, 1:00 PM

Remove build for python2.

DataDrake accepted this revision.Nov 18 2019, 5:25 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

DataDrake requested changes to this revision.Nov 18 2019, 6:16 AM

Missing a Makefile.

This revision now requires changes to proceed.Nov 18 2019, 6:16 AM
ma-renaud updated this revision to Diff 18427.Nov 20 2019, 1:48 PM

Makefile added.

DataDrake accepted this revision.Nov 26 2019, 12:40 AM
DataDrake removed a reviewer: kyrios123.

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 26 2019, 12:40 AM
This revision was automatically updated to reflect the committed changes.