Page MenuHomeSolus

Update android-tools to 29.0.4
ClosedPublic

Authored by chax on Sep 6 2019, 8:56 AM.

Details

Summary

Update android-tools to 29.0.4

  • cleaned up package.yaml
  • switch to platform tools version tags for git sources
  • updated patches so they work with new sources
  • updated generate_build ruby script so it works with new sources
Test Plan

Built, installed and issued few adb and fastboot commands

Diff Detail

Repository
R4737 android-tools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Sep 6 2019, 8:56 AM
chax requested review of this revision.Sep 6 2019, 8:56 AM
chax updated this revision to Diff 17270.Sep 19 2019, 8:47 PM
chax retitled this revision from Update android-tools to 29.0.2 to Update android-tools to 29.0.3.
chax edited the summary of this revision. (Show Details)

Update to version 29.0.3, cleaned up patches

chax updated this revision to Diff 17478.Oct 1 2019, 12:49 PM
chax retitled this revision from Update android-tools to 29.0.3 to Update android-tools to 29.0.4.
chax edited the summary of this revision. (Show Details)

Update to 29.0.4

JoshStrobl requested changes to this revision.Oct 1 2019, 12:57 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
55–56

Should be -Dm00755, quotes around $installdir aren't needed

This revision now requires changes to proceed.Oct 1 2019, 12:57 PM
chax updated this revision to Diff 17482.Oct 1 2019, 12:59 PM

fix after review remarks

JoshStrobl accepted this revision.Oct 1 2019, 1:05 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 1 2019, 1:05 PM
This revision was automatically updated to reflect the committed changes.