Page MenuHomeSolus

Update simplenote to 1.8.0
ClosedPublic

Authored by algent on Sun, Sep 1, 8:22 PM.

Details

Summary

Update to 1.8.0

Changelog:

  • Accessibility fixes
  • Dependency update

Added a new builddep: pkgconfig(gtk+-3.0) because of libgdk-3.so.0, libgtk-3.so.0 and libatk-bridge-2.0.so.0.
Removed builddep: pkgconfig(fontconfig) and pkgconfig(gtk+-2.0)

Test Plan

Deleted a note, created a new note, published it and checked the link.

Diff Detail

Repository
R2907 simplenote
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Sun, Sep 1, 8:22 PM
algent requested review of this revision.Sun, Sep 1, 8:22 PM
JoshStrobl requested changes to this revision.Tue, Sep 3, 3:45 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
15

Why...we already have the gtk+-3.0 pkgconfig, this isn't needed.

This revision now requires changes to proceed.Tue, Sep 3, 3:45 PM
algent added a comment.Tue, Sep 3, 4:45 PM

I added pkgconfig(gdk-3.0) because of these errors during build:
Fatal: Unknown symbol: libgdk-3.so.0
Fatal: Unknown symbol: libatk-bridge-2.0.so.0
Fatal: Unknown symbol: libgtk-3.so.0

After including pkgconfig(gdk-3.0) they were recognised as three other dependencies:
[Dependency] /usr/share/Simplenote/simplenote adds dependency on libgdk-3.so.0 from libgtk-3
[Dependency] /usr/share/Simplenote/simplenote adds dependency on libatk-bridge-2.0.so.0 from at-spi2-atk
[Dependency] /usr/share/Simplenote/simplenote adds dependency on libgtk-3.so.0 from libgtk-3

I added pkgconfig(gdk-3.0) because of these errors during build:
Fatal: Unknown symbol: libgdk-3.so.0
Fatal: Unknown symbol: libatk-bridge-2.0.so.0
Fatal: Unknown symbol: libgtk-3.so.0
After including pkgconfig(gdk-3.0) they were recognised as three other dependencies:
[Dependency] /usr/share/Simplenote/simplenote adds dependency on libgdk-3.so.0 from libgtk-3
[Dependency] /usr/share/Simplenote/simplenote adds dependency on libatk-bridge-2.0.so.0 from at-spi2-atk
[Dependency] /usr/share/Simplenote/simplenote adds dependency on libgtk-3.so.0 from libgtk-3

Sorry, I misread the gtk 2.x dep as 3.0. Change the gdk-3.0 to gtk+-3.0, drop the gtk 2 builddep and see if you get any further unknown symbols. It'll largely depend on the version of Electron they're using whether or not it'll be problematic. If you get unknown symbols after removing the gtk2 pkgconfig, have both the gtk 3 and gtk 2 builddeps.

algent updated this revision to Diff 16993.Tue, Sep 3, 5:26 PM
algent marked an inline comment as done.

Replaced pkgconfig(gdk-3.0) with pkgconfig(gtk+-3.0) and removed pkgconfig(gtk+-2.0).

algent edited the summary of this revision. (Show Details)Tue, Sep 3, 5:30 PM
JoshStrobl accepted this revision.Tue, Sep 3, 6:01 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Sep 3, 6:01 PM
This revision was automatically updated to reflect the committed changes.