Page MenuHomeSolus

Update license and update summary
ClosedPublic

Authored by Jacalz on Aug 30 2019, 6:58 PM.

Details

Summary

This commit simply updates the license and cleans up the summary.

Test Plan
  • Convert wav file to mp3 file.

Diff Detail

Repository
R1599 lame
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Aug 30 2019, 6:58 PM
Jacalz requested review of this revision.Aug 30 2019, 6:58 PM
Jacalz added inline comments.Aug 30 2019, 8:34 PM
package.yml
6–7

Can’t honestly find anything about which version it uses for LGPL. It just mentions LGPL and nothing else. Should I change it to version 1.0?

Jacalz added inline comments.Aug 30 2019, 8:46 PM
package.yml
6–7

As a further note, it seems that version 2.1 was released around the time that they switched to LGPL. Should I just keep it as is?

Source code headers tell you which version:

/*
 *      Version numbering for LAME.
 *
 *      Copyright (c) 1999 A.L. Faber
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Library General Public
 * License as published by the Free Software Foundation; either
 * version 2 of the License, or (at your option) any later version.
JoshStrobl accepted this revision.Oct 1 2019, 12:57 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Oct 1 2019, 12:57 PM
This revision was automatically updated to reflect the committed changes.