Page MenuHomeSolus
Differential D7052

T8298 - Fix geary consume all cpu due to upstream bug in handling some UTF in a mail header string
ClosedPublic
Actions

Authored by ArjenR on Aug 29 2019, 7:45 AM.
Tags
None
Referenced Files
F11054835: D7052.id.diff
Fri, Aug 11, 1:14 AM
F11054834: D7052.id16913.diff
Fri, Aug 11, 1:14 AM
F11054833: D7052.id16885.diff
Fri, Aug 11, 1:14 AM
F11054832: D7052.id16889.diff
Fri, Aug 11, 1:14 AM
F11054831: D7052.id16887.diff
Fri, Aug 11, 1:14 AM
F11054830: D7052.id16888.diff
Fri, Aug 11, 1:14 AM
F11054829: D7052.id16901.diff
Fri, Aug 11, 1:14 AM
F11038273: D7052.diff
Wed, Aug 9, 10:25 PM
View All 19 Files
Subscribers
chax
davidjharder
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R884:b9367c272339: T8298 - Fix geary consume all cpu due to upstream bug in handling some UTF in a…
Summary

This patch resolves the issue mentioned in T8298 - Geary 3.32.1 high cpu due to upstream bug

Geary can continuously use all available cpu due to an upstream bug in handling some UTF in a mail header string
This is described here: https://gitlab.gnome.org/GNOME/geary/issues/504
A patch for the current mainline has been provided and was merged into mainline:
https://gitlab.gnome.org/GNOME/geary/commit/2025aa24e11219664ff4bd8f5017d63683b7dd45

I have cherry picked this commit into tags/geary-3.32.1 which applied without issue.

From there I created a patch file which I added to the solus geary build as a patch.
This builds cleanly and resolves the issue for me.

Test Plan

Upgrade an existing installation of Geary in which the issue can be observed and see if CPU consumption goes down after intial mailbox and mail folder scanning.

Diff Detail

Repository
R884 geary
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ArjenR created this revision.Aug 29 2019, 7:45 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptAug 29 2019, 7:45 AM
ArjenR requested review of this revision.Aug 29 2019, 7:45 AM
davidjharder added a subscriber: davidjharder.EditedAug 29 2019, 12:07 PM

Also, your diff should include the pspec_*.xml file and the ABI report: files starting with abi_*.

package.yml
3

Bump this to 24

ArjenR added a comment.Aug 29 2019, 12:18 PM

Even if those were not changed? I added them to git and amended the commit. But since there are no changes in those, nothing extra get's picked up.

ArjenR updated this revision to Diff 16887.Aug 29 2019, 12:21 PM

(tried to) add pspec_*.xml abi_*

ArjenR updated this revision to Diff 16888.Aug 29 2019, 12:23 PM

bump release nr

chax added a subscriber: chax.Aug 29 2019, 12:32 PM

You need to run make. That way you will get changes on those files. But first you need to setup local environment for solbuild.
Read articles that i linked in original issue. Start with this one: https://getsol.us/articles/packaging/building-a-package/en/

ArjenR updated this revision to Diff 16889.Aug 29 2019, 1:01 PM
ArjenR marked an inline comment as done.

properly built for unstable

davidjharder added a comment.EditedAug 29 2019, 2:39 PM

I should have checked this earlier: the geary repository has a MAINTAINERS file. This diff will probably be abandoned.

JoshStrobl added a subscriber: JoshStrobl.Aug 29 2019, 3:04 PM

How about everybody except global maintainers and core team refrain from reviewing patches? Thanks.

JoshStrobl requested changes to this revision.Aug 29 2019, 3:05 PM

Patch looks fine but you're required to use your real name for accountability purposes.

This revision now requires changes to proceed.Aug 29 2019, 3:05 PM
ArjenR updated this revision to Diff 16901.Aug 29 2019, 3:19 PM

Using real name for accountability purposes.

JoshStrobl accepted this revision.Aug 29 2019, 3:44 PM

Thanks @ArjenR for the patch, LGTM!

This revision is now accepted and ready to land.Aug 29 2019, 3:44 PM
Closed by commit R884:b9367c272339: T8298 - Fix geary consume all cpu due to upstream bug in handling some UTF in a… (authored by ArjenR, committed by JoshStrobl). · Explain WhyAug 29 2019, 3:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16913

View Options

files/utfmismatch-rfc822string.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.