Page MenuHomeSolus

Update to 2.10, enable pkgconfig
ClosedPublic

Authored by chax on Aug 28 2019, 2:20 PM.

Details

Summary

Update to 2.10

  • packaging: removed component.xml, define component in package.yml
  • new release comes with improved build (autoconf, cmake)
  • lzo lib now provides pkgconfig
  • no abi changes
Test Plan
  • rebuild reverse dependency lzop
  • change lzop builddep from lzo-devel to pkgconfig(lzo2)
  • rebuild lzop using pkgconfig version of lzo lib
  • use rebuilt lzop to de-/compress files

Diff Detail

Repository
R2002 lzo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Aug 28 2019, 2:20 PM
chax requested review of this revision.Aug 28 2019, 2:20 PM
livingsilver94 added inline comments.
package.yml
5–9

HTTPS is available, I'd use it.

livingsilver94 added inline comments.Aug 28 2019, 3:32 PM
package.yml
12–13

Flags should be listed alphabetically.

chax added inline comments.Aug 29 2019, 6:53 AM
package.yml
12–13

do we really need to sort this alphabetically? I would say that this looks cleaner...

chax updated this revision to Diff 16884.Aug 29 2019, 6:55 AM

Set https instead of http for fetching tarball

chax updated this revision to Diff 16938.Aug 29 2019, 9:21 PM

git commit author update

JoshStrobl requested changes to this revision.Oct 1 2019, 1:39 PM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM.

package.yml
7

Given this doesn't actually provide any utilities and is just a library, let's move it to programming.library

This revision now requires changes to proceed.Oct 1 2019, 1:39 PM
chax updated this revision to Diff 17487.Oct 1 2019, 1:43 PM

update component

JoshStrobl accepted this revision.Oct 1 2019, 1:53 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 1 2019, 1:53 PM
This revision was automatically updated to reflect the committed changes.