Paths

Table of Contentst

Differential D7046

Riot: install default configuration
ClosedPublic
Actions

Authored by silke on Aug 28 2019, 10:23 AM.

Tags

None

Referenced Files

	F11069424: D7046.id16875.diff
	Fri, Aug 11, 11:02 PM

	F11069423: D7046.id16873.diff
	Fri, Aug 11, 11:02 PM

	F11051726: D7046.diff
	Thu, Aug 10, 8:15 PM

	F10772837: D7046.id16875.diff
	May 21 2023, 3:07 PM

	F10772764: D7046.id16873.diff
	May 21 2023, 2:43 PM

	F10772761: D7046.id16872.diff
	May 21 2023, 2:42 PM

	F10772737: D7046.diff
	May 21 2023, 2:35 PM

Subscribers

Details

Reviewers

Girtablulu
JoshStrobl

Group Reviewers

Maniphest Tasks

T8296: Riot: invalid default configuration

Commits

R2816:1d4cceb64273: Riot: install default configuration

Summary

Resolves T8296

Test Plan

Start Riot, confirm error has been resolved

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

silke created this revision.Aug 28 2019, 10:23 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 28 2019, 10:23 AM

silke requested review of this revision.Aug 28 2019, 10:23 AM

chax added a subscriber: chax.Aug 28 2019, 11:08 AM

chax added inline comments.

package.yml
40	rather use install command than cp install -Dm644 electron_app/riot.im/config.json-t $installdir/usr/share/riot/resources/webapp/

chax added inline comments.Aug 28 2019, 11:12 AM

package.yml
40	use -Dm00644 to be consistent with rest of the package.yml

Girtablulu requested changes to this revision.Aug 28 2019, 11:13 AM

This revision now requires changes to proceed.Aug 28 2019, 11:13 AM

Use install instead of cp

JoshStrobl accepted this revision.Aug 28 2019, 2:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 2:16 PM

Closed by commit R2816:1d4cceb64273: Riot: install default configuration (authored by silke, committed by JoshStrobl). · Explain Why

This revision was automatically updated to reflect the committed changes.

Ah cool, I thought that the last version had probably already solved that issue, since there was a similar item on the changelog; thanks for actually testing and fixing it.

Revision Contents
Changeset List

Path

Size

5 lines

pspec_x86_64.xml

13 lines

Diff 16875

package.yml

Loading...

pspec_x86_64.xml

Loading...