Page MenuHomeSolus

Initial inclusion of podman
ClosedPublic

Authored by chax on Aug 17 2019, 12:40 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8202: Podman
Commits
R4790:527494b4c4a7: Initial inclusion of podman
Summary

Initial inclusion of podman
A daemonless container engine for developing, managing, and running Open Container Initiative (OCI) containers and container images.

Resolves T8202
Depends on D6979, D6980, D6981, D6982

Test Plan

Run a few podman commands:

  • podman pull busybox
  • podman images
  • podman run -it busybox sh
  • podman ps
  • podman image rm -f busybox

Diff Detail

Repository
R4790 podman
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Aug 17 2019, 12:40 AM
chax requested review of this revision.Aug 17 2019, 12:40 AM
chax retitled this revision from Initial inclusiion of podman to Initial inclusion of podman.Aug 17 2019, 7:37 PM
JoshStrobl requested changes to this revision.Aug 20 2019, 1:32 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
2

We are we calling this podman when the repo itself is libpod?

13

You should evaluate if this is actually needed.

15–26

Alphabets...

44–46

See my comment on buildah for what you should be doing.

This revision now requires changes to proceed.Aug 20 2019, 1:32 PM
chax added inline comments.Aug 20 2019, 2:40 PM
package.yml
2

Because it is called podman. For some reason, their github repo is called libpod (i guess it was library only before, and then it became podman)

13

Tested without networking and it builds. I assumed wrongly that we need it to fetch go dependencies.

r3r57 added a subscriber: r3r57.Aug 20 2019, 6:37 PM
r3r57 awarded a token.Aug 20 2019, 6:41 PM
chax updated this revision to Diff 16781.Aug 20 2019, 7:24 PM

cleaned up package.yml

JoshStrobl requested changes to this revision.Aug 23 2019, 1:04 PM

pkgconfig builddeps should also be alphabetized, runc removed as a rundep since it'll be a dep of conman.

package.yml
16

Not needed, is a dep of gpgme

21

Not needed, is a rundep of only about a billion other things.

23

Not needed, this is a rundep of gpgme-devel

47

Should also have SYSTEMDDIR=%libdir%/systemd/system and USERSYSTEMDDIR=%libdir%/systemd/user (basically we're correcting /usr/lib to /usr/lib64/)

This revision now requires changes to proceed.Aug 23 2019, 1:04 PM
chax updated this revision to Diff 16833.Aug 23 2019, 9:05 PM

Cleaned up builddeps and rundeps, fixed make_install for correct libdir

This revision is now accepted and ready to land.Aug 27 2019, 4:25 PM
This revision was automatically updated to reflect the committed changes.