Page MenuHomeSolus

Initial inclusion of CoreCtrl
ClosedPublic

Authored by EbonJaeger on Aug 11 2019, 5:19 PM.

Details

Summary

Initial inclusion of CoreCtrl, a hardware controller software.

Depends on D6925
Resolves T8150

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>

Test Plan
  • Created new profile for RimWorld
  • Verified settings worked as expected when running profile

Diff Detail

Repository
R4804 corectl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

EbonJaeger created this revision.Aug 11 2019, 5:19 PM
EbonJaeger requested review of this revision.Aug 11 2019, 5:19 PM
Girtablulu added inline comments.
package.yml
16

not needed gets pulled in as rev dep

21

pkgconfig(Qt5UiTools)

Girtablulu requested changes to this revision.Aug 11 2019, 5:31 PM
This revision now requires changes to proceed.Aug 11 2019, 5:31 PM
EbonJaeger updated this revision to Diff 16603.Aug 11 2019, 5:49 PM

Fix build dependencies

EbonJaeger marked 2 inline comments as done.Aug 11 2019, 5:50 PM
Lorien added a subscriber: Lorien.Aug 22 2019, 9:49 PM
JoshStrobl requested changes to this revision.Aug 23 2019, 1:10 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
22

Not needed per abi_used_libs

23–24

Not needed per abi_used_libs

25

Not needed, qt5-charts is marked as a rundep per the abi_used_libs indicating libQt5Charts.so.5

This revision now requires changes to proceed.Aug 23 2019, 1:10 PM
EbonJaeger updated this revision to Diff 16840.Aug 24 2019, 2:21 PM

Removed un-needed rundeps and built against latest botan2 diff.

EbonJaeger marked 3 inline comments as done.Aug 24 2019, 2:22 PM
JoshStrobl accepted this revision.Aug 29 2019, 4:59 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 5:24 PM
This revision was automatically updated to reflect the committed changes.