Page MenuHomeSolus

Initial inclusion of botan2
ClosedPublic

Authored by EbonJaeger on Aug 11 2019, 5:17 PM.

Details

Summary

Botan2 is a C++ cryptography library.

Required for T8150

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>

Test Plan

Built CoreCtrl successfully using this package

Diff Detail

Repository
R4803 botan2
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

EbonJaeger created this revision.Aug 11 2019, 5:17 PM
EbonJaeger requested review of this revision.Aug 11 2019, 5:17 PM
JoshStrobl requested changes to this revision.Aug 23 2019, 1:06 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13–16

I imagine a fair few of those can be removed by doing python3 ./configure.py %CONFOPTS% instead. See https://github.com/getsolus/ypkg/blob/master/ypkg2/rc.yml#L326

pspec_x86_64.xml
404

Static should be disabled or removed.

This revision now requires changes to proceed.Aug 23 2019, 1:06 PM

Sadly this thing expects a few different keys than what %CONFOPTS% uses, and using it breaks the configuring. :/

EbonJaeger updated this revision to Diff 16830.Aug 23 2019, 8:10 PM

Disable creation of static library

EbonJaeger marked an inline comment as done.Aug 23 2019, 8:11 PM
JoshStrobl accepted this revision.EditedAug 29 2019, 4:59 PM

LGTM, thanks! Disappointed to hear they don't accept all of the standard configure flags but oh well.

This revision is now accepted and ready to land.Aug 29 2019, 4:59 PM
This revision was automatically updated to reflect the committed changes.