Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R4672:3aa6379d6177: Update pytorch to 1.3.0

Summary

Update pytorch to 1.3.0.

Changelog available here.

Test Plan

Ran the demo snippet.
Ran the MNIST example.

Diff Detail

Repository

R4672 pytorch

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

xulongwu4 created this revision.Aug 9 2019, 10:45 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 9 2019, 10:45 AM

xulongwu4 requested review of this revision.Aug 9 2019, 10:45 AM

xulongwu4 retitled this revision from Update to 1.2.0 to Update pytorch to 1.2.0.Aug 9 2019, 10:48 AM

Add patch to build with opencv-4

xulongwu4 mentioned this in T8142: Update opencv to 4.1.0.Aug 11 2019, 1:32 AM

pytorch-devel belongs to programming.library now

Will need to be rebased against R4672:f70316c55e2d, sorry for being a PITA.

Rebase on master branch

@xulongwu4, is the patch for OpenCV 4 needed? Because we have got 3.4.7 version in our repo.

In D6912#116158, @maverick1 wrote:

@xulongwu4, is the patch for OpenCV 4 needed? Because we have got 3.4.7 version in our repo.

@maverick1 The patch is there so that T8142 is not blocked by pytorch.

Update to 1.3.0

xulongwu4 retitled this revision from Update pytorch to 1.2.0 to Update pytorch to 1.3.0.Oct 11 2019, 12:15 PM

xulongwu4 edited the summary of this revision. (Show Details)

I think it is not rebased properly!

Rebase against master branch

@JoshStrobl Can you review this patch again?

JoshStrobl requested changes to this revision.Oct 18 2019, 12:24 PM

JoshStrobl added inline comments.

package.yml
9	Should be programming.devel, not sure why you'd change this.

This revision now requires changes to proceed.Oct 18 2019, 12:24 PM

-devel subpackage belongs to programming.devel component

xulongwu4 marked an inline comment as done.Oct 18 2019, 2:48 PM

JoshStrobl requested changes to this revision.Oct 18 2019, 4:03 PM

JoshStrobl added inline comments.

package.yml
9	ypkg should automatically set it to programming.devel

This revision now requires changes to proceed.Oct 18 2019, 4:03 PM

Let ypkg decide the component for devel subpackage

xulongwu4 marked an inline comment as done.Oct 18 2019, 4:48 PM

xulongwu4 added inline comments.

package.yml
9	Should be fixed now

xulongwu4 marked an inline comment as done.Oct 18 2019, 4:50 PM

@JoshStrobl Can you take a look at the patch again to see whether it is good now?

Yep, LGTM. Thanks!

This revision is now accepted and ready to land.Oct 23 2019, 7:45 PM

Closed by commit R4672:3aa6379d6177: Update pytorch to 1.3.0 (authored by xulongwu4, committed by JoshStrobl). · Explain WhyOct 23 2019, 7:46 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4672:3aa6379d6177: Update pytorch to 1.3.0.

Update pytorch to 1.3.0
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 17938

abi_used_libs

package.yml

pspec_x86_64.xml

Update pytorch to 1.3.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17938

abi_used_libs

package.yml

pspec_x86_64.xml

Update pytorch to 1.3.0
ClosedPublic
Actions

Revision Contents
Changeset List