Page MenuHomeSolus

Update pytorch to 1.3.0
ClosedPublic

Authored by xulongwu4 on Aug 9 2019, 10:45 AM.

Details

Summary

Update pytorch to 1.3.0.

Changelog available here.

Test Plan

Diff Detail

Repository
R4672 pytorch
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

xulongwu4 created this revision.Aug 9 2019, 10:45 AM
xulongwu4 requested review of this revision.Aug 9 2019, 10:45 AM
xulongwu4 retitled this revision from Update to 1.2.0 to Update pytorch to 1.2.0.Aug 9 2019, 10:48 AM
xulongwu4 updated this revision to Diff 16592.Aug 11 2019, 1:30 AM

Add patch to build with opencv-4

xulongwu4 updated this revision to Diff 16624.Aug 13 2019, 1:35 AM

pytorch-devel belongs to programming.library now

Will need to be rebased against R4672:f70316c55e2d, sorry for being a PITA.

xulongwu4 updated this revision to Diff 17541.Oct 3 2019, 11:37 PM

Rebase on master branch

@xulongwu4, is the patch for OpenCV 4 needed? Because we have got 3.4.7 version in our repo.

@xulongwu4, is the patch for OpenCV 4 needed? Because we have got 3.4.7 version in our repo.

@maverick1 The patch is there so that T8142 is not blocked by pytorch.

xulongwu4 updated this revision to Diff 17636.Oct 11 2019, 12:14 PM

Update to 1.3.0

xulongwu4 retitled this revision from Update pytorch to 1.2.0 to Update pytorch to 1.3.0.Oct 11 2019, 12:15 PM
xulongwu4 edited the summary of this revision. (Show Details)

I think it is not rebased properly!

xulongwu4 updated this revision to Diff 17637.Oct 11 2019, 12:34 PM

Rebase against master branch

@JoshStrobl Can you review this patch again?

JoshStrobl requested changes to this revision.Oct 18 2019, 12:24 PM
JoshStrobl added inline comments.
package.yml
9

Should be programming.devel, not sure why you'd change this.

This revision now requires changes to proceed.Oct 18 2019, 12:24 PM
xulongwu4 updated this revision to Diff 17851.Oct 18 2019, 2:48 PM

-devel subpackage belongs to programming.devel component

xulongwu4 marked an inline comment as done.Oct 18 2019, 2:48 PM
JoshStrobl requested changes to this revision.Oct 18 2019, 4:03 PM
JoshStrobl added inline comments.
package.yml
9

ypkg should automatically set it to programming.devel

This revision now requires changes to proceed.Oct 18 2019, 4:03 PM
xulongwu4 updated this revision to Diff 17856.Oct 18 2019, 4:47 PM

Let ypkg decide the component for devel subpackage

xulongwu4 marked an inline comment as done.Oct 18 2019, 4:48 PM
xulongwu4 added inline comments.
package.yml
9

Should be fixed now

xulongwu4 marked an inline comment as done.Oct 18 2019, 4:50 PM

@JoshStrobl Can you take a look at the patch again to see whether it is good now?

JoshStrobl accepted this revision.Oct 23 2019, 7:45 PM

Yep, LGTM. Thanks!

This revision is now accepted and ready to land.Oct 23 2019, 7:45 PM
This revision was automatically updated to reflect the committed changes.