Page MenuHomeSolus

Update celluloid to 0.18
Needs ReviewPublic

Authored by Jacalz on Aug 8 2019, 4:40 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Summarized Changelog:

  • Rename gnome-mpv to Celluloid.
  • Add Turkish and Esperanto translations.
  • Migrate from opengl-cb to the new render API.
  • Handle numpad and unicode keybindings.
  • Forward media key events to mpv.
  • Add dconf key for controlling cursor speed threshold for unhiding controls.
  • Add option for suppressing playback errors.
  • Add Persian translation by @danialbehzadi
  • Add Ukranian translation by @vl-nix
  • Add support for showing/hiding window decorations using the mpv option --border.
  • Add menu item for opening discs.
  • Block cursor autohide when volume popup is open in windowed mode.
  • Fix a crash when used with mpv 0.30.
Test Plan
  • Verify that big buck bunny with x265 encoding plays as expected.
  • test a regular x264 video of .mov format and test that subtitles work.

Diff Detail

Repository
R975 gnome-mpv
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacalz created this revision.Aug 8 2019, 4:40 PM
Jacalz requested review of this revision.Aug 8 2019, 4:40 PM
Jacalz added a comment.Aug 8 2019, 4:41 PM

I will send a merge request tomorrow for the deprecation of gnome-mpv.

This is also going to involve me needing to make changes to our branding packages, so I'm going to be a bit conservative when it comes to landing this and making sure it happens post-sync. Thank you for the patch however, as well as to the solus-sc repo!

JoshStrobl requested changes to this revision.Oct 1 2019, 1:37 PM

Sorry for the delay, is there any chance we could get a symlink of the celluloid desktop file to io.github.GnomeMpv.desktop? That way existing pinned instances of GNOME MPV should still work. Thanks!

This revision now requires changes to proceed.Oct 1 2019, 1:37 PM
Jacalz added a comment.Oct 1 2019, 4:56 PM

Sorry for the delay, is there any chance we could get a symlink of the celluloid desktop file to io.github.GnomeMpv.desktop? That way existing pinned instances of GNOME MPV should still work. Thanks!

Doesn't that mean that the users will see two entries in their menus?

Sorry for the delay, is there any chance we could get a symlink of the celluloid desktop file to io.github.GnomeMpv.desktop? That way existing pinned instances of GNOME MPV should still work. Thanks!

Doesn't that mean that the users will see two entries in their menus?

Well we could just have a desktop file that is marked as Hidden=true, that should prevent it from showing up but may still work if pinned. More testing probably needed.

Jacalz added a comment.Oct 1 2019, 7:09 PM

I am running Budgie and I am having severe issues getting a pinned version of Gnome MPV to even start from the panel. I have tested straight out renaming the desktop file to the old file name, installing the old desktop file but with modifications for celluloid (and to be hidden) and the new desktop file with modifications to be hidden. For the first one it shows up in the menu perfectly but all of them won't start when pressed from the pinned instance in the panel. Setting the desktop files to not be hidden makes them show up in the menu and they do work, but as I said the Budgie panel doesn't want to start them when pinned for me...

As stated in the above comments, I am having weird issues when trying to make the old pinned Gnome-MPV work in Budgie. Have you been able to test it out? @JoshStrobl

I just can't get seem to get any good transition from the gnome-mpv desktop file to work. All the suggestions you gave some how just makes it so celluloid doesn't want to open using the desktop file. Any ideas? @JoshStrobl
If I can't come up with any fixes for the transition, do you want me to abandon this?

No we should probably just abandon the effort to get it to transition smoothly with this specific method. I can update our branding packages (for Budgie and GNOME) to ensure new installs are able to transition smoothly assuming no changes are made to the default icon tasklist favorites, but I'll want to pull this patch down locally and test a "fix" to Budgie to try to load io.github.celluloid_player.Celluloid.desktop in the event we specifically fail to load io.github.GnomeMpv.desktop, then proceed to update the pinned value for it in gsettings.

If usysconf wasn't completely over-engineered and the port from C to Go was complete, I could avoid all of entirely by having a usysconf trigger to fix it but that simply isn't the reality.

The patch itself looks good but I'm going to keep this as requesting changes (though none are necessary) until I get fixes worked out.

Alright. Thanks for the information :)

@Jacalz Sorry for accidentally "breaking" this update, but I stumbled upon a warning in Celluloid 0.17 changelog:

With mpv >= 0.30, Celluloid may crash during UI interactions. Apply this patch to fix.

So, given that we moved to mpv 0.30, you may want to apply this patch before Celluloid 0.17 lands in repo.

Jacalz added a comment.EditedNov 5 2019, 4:25 PM

@Jacalz Sorry for accidentally "breaking" this update, but I stumbled upon a warning in Celluloid 0.17 changelog:

With mpv >= 0.30, Celluloid may crash during UI interactions. Apply this patch to fix.

So, given that we moved to mpv 0.30, you may want to apply this patch before Celluloid 0.17 lands in repo.

Thank you very much for the heads up. I will make sure to apply the patch :)
EDIT: I will instead update to the 0.18 release that was recently released...

Jacalz updated this revision to Diff 18148.Nov 5 2019, 4:47 PM
  • Update to 0.18 to fix issues when used with mpv > v0.30
Jacalz retitled this revision from Update celluloid to 0.17 to Update celluloid to 0.18.Nov 5 2019, 4:49 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the test plan for this revision. (Show Details)
Jacalz updated this revision to Diff 19510.Sun, Feb 2, 1:25 PM
  • Just a safety rebuild in 2020