Page MenuHomeSolus

Update celluloid to 0.17
Needs RevisionPublic

Authored by Jacalz on Aug 8 2019, 4:40 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Summarized Changelog:

  • Rename gnome-mpv to Celluloid.
  • Add Turkish and Esperanto translations.
  • Migrate from opengl-cb to the new render API.
  • Handle numpad and unicode keybindings.
  • Forward media key events to mpv.
  • Add dconf key for controlling cursor speed threshold for unhiding controls.
  • Add option for suppressing playback errors.
Test Plan
  • Verify that big buck bunny with x265 encoding plays as expected.

Diff Detail

Repository
R975 gnome-mpv
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Jacalz created this revision.Aug 8 2019, 4:40 PM
Jacalz requested review of this revision.Aug 8 2019, 4:40 PM
Jacalz added a comment.Aug 8 2019, 4:41 PM

I will send a merge request tomorrow for the deprecation of gnome-mpv.

This is also going to involve me needing to make changes to our branding packages, so I'm going to be a bit conservative when it comes to landing this and making sure it happens post-sync. Thank you for the patch however, as well as to the solus-sc repo!

JoshStrobl requested changes to this revision.Tue, Oct 1, 1:37 PM

Sorry for the delay, is there any chance we could get a symlink of the celluloid desktop file to io.github.GnomeMpv.desktop? That way existing pinned instances of GNOME MPV should still work. Thanks!

This revision now requires changes to proceed.Tue, Oct 1, 1:37 PM
Jacalz added a comment.Tue, Oct 1, 4:56 PM

Sorry for the delay, is there any chance we could get a symlink of the celluloid desktop file to io.github.GnomeMpv.desktop? That way existing pinned instances of GNOME MPV should still work. Thanks!

Doesn't that mean that the users will see two entries in their menus?

Sorry for the delay, is there any chance we could get a symlink of the celluloid desktop file to io.github.GnomeMpv.desktop? That way existing pinned instances of GNOME MPV should still work. Thanks!

Doesn't that mean that the users will see two entries in their menus?

Well we could just have a desktop file that is marked as Hidden=true, that should prevent it from showing up but may still work if pinned. More testing probably needed.

Jacalz added a comment.Tue, Oct 1, 7:09 PM

I am running Budgie and I am having severe issues getting a pinned version of Gnome MPV to even start from the panel. I have tested straight out renaming the desktop file to the old file name, installing the old desktop file but with modifications for celluloid (and to be hidden) and the new desktop file with modifications to be hidden. For the first one it shows up in the menu perfectly but all of them won't start when pressed from the pinned instance in the panel. Setting the desktop files to not be hidden makes them show up in the menu and they do work, but as I said the Budgie panel doesn't want to start them when pinned for me...