Page MenuHomeSolus

Update ladspa to version 1.15
ClosedPublic

Authored by Jacalz on Aug 8 2019, 1:01 PM.

Details

Summary

Summarized Changelog:

  • Modernise C++ #include style.
  • Make some globals static.
  • Use mkdir -p rather than mkdirhier during build.
  • Use GCC export map to ensure only the ladspa_descriptor() exported.
  • Put libraries at the end of link instructions.
  • Package with version number in archive and directory names.
  • Fix bug in LADSPA plugin search which did not handle shared libraries that are not plugins correctly.
  • Introduce a default LADSPA plugin search path.
  • Perform macro string expansion in C code rather than in Makefile for better portability.
  • Modernise init()/fini() style in GNU C plugin builds (not C++), tweak link line to correspond.
Test Plan
  • Rebuild LMMS and verify that the ladspa plugins work.
  • Use the new ladspa version on system and use ladspa lugins in (non recompiled) ardour session.

Diff Detail

Repository
R1597 ladspa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Aug 8 2019, 1:01 PM
Jacalz requested review of this revision.Aug 8 2019, 1:01 PM
Jacalz updated this revision to Diff 16568.Aug 8 2019, 1:03 PM

Delete unused patch

Jacalz updated this revision to Diff 16569.Aug 8 2019, 1:04 PM

Remove old component.xml file

Jacalz updated this revision to Diff 17504.Oct 1 2019, 4:44 PM
  • Use the correct way of using variable macros

While you’re at it I would like to get this reviewed too if you don’t mind πŸ™‚

JoshStrobl accepted this revision.Oct 11 2019, 3:22 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Oct 11 2019, 3:22 PM
This revision was automatically updated to reflect the committed changes.