Page MenuHomeSolus

Update zynaddsubfx to 3.0.5
ClosedPublic

Authored by Jacalz on Aug 8 2019, 9:05 AM.

Details

Summary

Full changelog can be found here.

Test Plan
  • Played music through midi using both alsa and jack.

Diff Detail

Repository
R3335 zynaddsubfx
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Aug 8 2019, 9:05 AM
Jacalz requested review of this revision.Aug 8 2019, 9:05 AM
Jacalz added inline comments.Aug 8 2019, 9:07 AM
package.yml
5–6

Needs git submodules to build

JoshStrobl added inline comments.
package.yml
17

Why was portaudio removed?

Jacalz added inline comments.Aug 8 2019, 10:50 AM
package.yml
17

I didn’t think that it was that useful when we have jack. Perhaps that was a poor discussion?

Jacalz updated this revision to Diff 16565.Aug 8 2019, 11:59 AM

Add back portaudio

Jacalz marked 2 inline comments as done.Aug 8 2019, 12:00 PM
JoshStrobl added inline comments.Aug 9 2019, 9:26 AM
package.yml
17

I mean, I'm not necessarily saying to add it back, I'm just trying to understand why it was removed. Care to explain the usecases of using portaudio over jack and vise-versa to someone not experienced in that particular area?

Jacalz added inline comments.Aug 9 2019, 11:07 AM
package.yml
17

To be honest, I don’t use portaudio that much, but it’s basically another sound server that makes it easy to write sound IO for more platforms. I thought that it was used as a separate backend like jack and alsa, but that doesn’t seem to be the case so I added it back...

Jacalz updated this revision to Diff 17397.Sep 28 2019, 3:09 PM
  • Rebuild against Gnome 3.34 updates

Would you mind re-reviewing this one? @JoshStrobl

JoshStrobl accepted this revision.Oct 11 2019, 3:02 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 11 2019, 3:02 PM
JoshStrobl retitled this revision from Update zynadsubfx to 3.0.5 to Update zynaddsubfx to 3.0.5.Oct 11 2019, 3:02 PM
This revision was automatically updated to reflect the committed changes.