Page MenuHomeSolus

Initial commit of yapf
ClosedPublic

Authored by EbonJaeger on Aug 6 2019, 5:57 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8212: yapf
Commits
R4782:691ad86d2142: Initial commit of yapf
Summary

Initial inclusion of yapf in the repository.

Resolves T8212

Test Plan
  • Created a badly formatted python file using the example in yapf's readme, and ensured it reformatted correctly with yapf -i <file>

Diff Detail

Repository
R4782 yapf
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

EbonJaeger created this revision.Aug 6 2019, 5:57 PM
EbonJaeger requested review of this revision.Aug 6 2019, 5:57 PM
JoshStrobl requested changes to this revision.Aug 7 2019, 7:33 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

Would make more sense in programming.tools IMO

This revision now requires changes to proceed.Aug 7 2019, 7:33 AM
EbonJaeger updated this revision to Diff 16548.Aug 7 2019, 3:01 PM

Changed software category to programming.tools

EbonJaeger marked an inline comment as done.Aug 7 2019, 3:01 PM
JoshStrobl accepted this revision.Aug 8 2019, 8:50 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 8 2019, 8:50 AM
This revision was automatically updated to reflect the committed changes.