Page MenuHomeSolus

Update graph-tool to version 2.29
Needs RevisionPublic

Authored by padraig on Tue, Aug 6, 4:37 PM.

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8229: Update graph-tool to 2.29
Summary

Changelog available here
Fixes T8229

Test Plan
$ python3
>>> import graph_tool.all as gt
>>> g = gt.Graph()
>>> g.add_edge(0,1)
>>> gt.interactive_window(g)

Diff Detail

Repository
R4213 graph-tool
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
padraig requested review of this revision.Tue, Aug 6, 4:37 PM
padraig created this revision.
padraig updated this revision to Diff 16529.Tue, Aug 6, 4:43 PM
padraig retitled this revision from Update to version 2.29 to fix T8229 Update flags to reduce memory usage during the build to Update to version 2.29 to fix T8229.
padraig edited the summary of this revision. (Show Details)
padraig edited the test plan for this revision. (Show Details)

Fixed test plan

Jacalz added a subscriber: Jacalz.Tue, Aug 6, 4:51 PM
Jacalz added inline comments.
package.yml
7

License should be switched back to GPL-3.0-or-later.

13

You can remove the extra space from here ;)

21

You can add matplotlib back to it’s original place so the list is ordered alphabetically again.

26

Is there anything wrong with the %configure macro here?

kyrios123 retitled this revision from Update to version 2.29 to fix T8229 to Update graph-tool to version 2.29.Tue, Aug 6, 5:23 PM
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 edited the test plan for this revision. (Show Details)
padraig updated this revision to Diff 16536.EditedTue, Aug 6, 7:10 PM

In case you're wondering why these changes crept in it's cause I had an older build on my computer which I used instead of going from the most recent version, not very used to doing this, hopefully it's okay now.

JoshStrobl requested changes to this revision.Thu, Aug 8, 3:46 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
pspec_x86_64.xml
365–366

None of this should be in /usr/local. Try adding PREFIX=/usr before the PYTHON bit on the configure line.

This revision now requires changes to proceed.Thu, Aug 8, 3:46 PM
padraig updated this revision to Diff 16587.Sat, Aug 10, 12:13 PM
padraig marked 4 inline comments as done.
  • Rebuilt with PREFIX=/usr
JoshStrobl accepted this revision.Fri, Aug 16, 9:35 AM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Aug 16, 9:35 AM
JoshStrobl requested changes to this revision.Fri, Aug 16, 9:39 AM

Your patch does not apply cleanly on top of master, have you been amending your git commits or making new ones?

This revision now requires changes to proceed.Fri, Aug 16, 9:39 AM

I've been ammending them. Should I just do the most recent as a commit? Apologies, I'm not used to using git so was just trying to follow the documentation.