Page MenuHomeSolus

Update Solaar to release 1.0.1
ClosedPublic

Authored by chax on Mon, Aug 5, 9:11 PM.

Details

Summary

Update Solaar to release 1.0.1
Fixes T8211
Since last release was 6 years ago there was a bunch of changes, too much to summarize them in a convenient list.
Among most notable changes are:

  • Updated existing translations
  • Added new translations:
    • Italian
    • Greek
    • German
    • Chinese (simplified)
    • Spanish
    • Turkish
    • Brazilian Portugese
    • Croatian
    • Russian
    • Taiwanese Mandarin
  • Support for new type of receivers (Lightspeed, Lenovo)
  • Support for MX Master 'Smart shift'
  • Support for adjustable DPI

Official release changelog can be found here
List of supported devices can be found here

Test Plan
  • Install Solaar
  • Run Solaar from start menu
  • Open Solaar settings from System tray
  • Open About Solaar
  • Change few settings and see if they are applied
  • Unpair MX Master from Unifying receiver
  • Pair MX Master to Unifying receiver

Diff Detail

Repository
R2922 solaar
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chax created this revision.Mon, Aug 5, 9:11 PM
chax requested review of this revision.Mon, Aug 5, 9:11 PM
Jacalz added a subscriber: Jacalz.Tue, Aug 6, 7:05 AM
Jacalz added inline comments.
package.yml
5–6

License should be GPL-2.0-or-later

JoshStrobl requested changes to this revision.Wed, Aug 7, 7:31 AM
JoshStrobl added a subscriber: JoshStrobl.

80 column is the devil. We're in 2019.

This revision now requires changes to proceed.Wed, Aug 7, 7:31 AM
chax added a comment.Wed, Aug 7, 8:23 AM

Hmmm @JoshStrobl what do you mean? Both description and summary are in single line and i didn't even touch those. What exactly needs to be changed?

In D6892#109177, @chax wrote:

Hmmm @JoshStrobl what do you mean? Both description and summary are in single line and i didn't even touch those. What exactly needs to be changed?

I'm talking about your changelog.

chax edited the summary of this revision. (Show Details)Wed, Aug 7, 8:23 PM
chax added a comment.Wed, Aug 7, 8:29 PM

I removed one new line break from changelog. I can also condense list of languages in a comma separated list in one line instead of current bullet list if you wish.
Do i also need to update licence as @Jacalz suggested?

Justin added a subscriber: Justin.Thu, Aug 8, 1:28 AM
In D6892#109220, @chax wrote:

I removed one new line break from changelog. I can also condense list of languages in a comma separated list in one line instead of current bullet list if you wish.
Do i also need to update licence as @Jacalz suggested?

Yes, licenses now need to be aligned with SPDX 3.0 as per https://spdx.org/licenses/

chax updated this revision to Diff 16571.Thu, Aug 8, 1:51 PM

Update licence

JoshStrobl accepted this revision.Thu, Aug 8, 2:00 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 8, 2:00 PM
Closed by commit R2922:9408f1fdb00b: Update Solaar to release 1.0.1 (authored by chax, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.