Page MenuHomeSolus

Update libTAS to 1.3.4
ClosedPublic

Authored by serebit on Aug 4 2019, 5:10 PM.

Details

Summary
  • Drag analog inputs in the input editor
  • Add some tooltips
  • Handle wait timeouts
  • Show recording/playback toggle in the OSD messages
  • Add shortcuts to some input editor options

Full changelog available here

Test Plan

Created a short TAS using Chocolate DOOM

Diff Detail

Repository
R4702 libTAS
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Aug 4 2019, 5:10 PM
serebit requested review of this revision.Aug 4 2019, 5:10 PM
This revision now requires changes to proceed.Aug 4 2019, 5:17 PM

I'm not sure what you mean. I followed the steps on that page, I used yupdate.py. If you mean I should resubmit without git commit --amend, I can do that.

serebit updated this revision to Diff 16475.Aug 4 2019, 5:22 PM

Changed commit to not amend previous commit

You need to clone the libtas git repo and base your work on that.

JoshStrobl requested changes to this revision.Aug 4 2019, 5:23 PM

Cheers. Please provide a summarized changelog (if there is any changelog)

This revision now requires changes to proceed.Aug 4 2019, 5:23 PM
serebit edited the summary of this revision. (Show Details)Aug 4 2019, 5:25 PM

You need to clone the libtas git repo and base your work on that.

I did. My mistake was running git commit --amend instead of just git commit when creating the differential.

Copy / pasting the entire changelog isn't what summary means...

serebit edited the summary of this revision. (Show Details)Aug 4 2019, 5:32 PM
JoshStrobl accepted this revision.Aug 4 2019, 5:51 PM

See, isn't that way better and something people will read? :D

LGTM, thanks!

This revision is now accepted and ready to land.Aug 4 2019, 5:51 PM
JoshStrobl edited the summary of this revision. (Show Details)Aug 4 2019, 5:51 PM
JoshStrobl edited the summary of this revision. (Show Details)

P.S. Do not use Phabricator editing for this, or at least use Markdown. That is what we use and support.

This revision was automatically updated to reflect the committed changes.