Page MenuHomeSolus

Initial inclusion of cloc
ClosedPublic

Authored by tomocafe on Jul 26 2019, 5:01 AM.

Details

Summary

Initial inclusion of cloc Depends on D6805, D6806 Resolves T8163

Test Plan

Clone budgie-desktop repository (e.g.), run cloc on both extracted directory and compressed archive. Run cloc --diff on HEAD vs. latest release to observe differences. Use cloc --processes to exercise multi-threading. Check man cloc.

Diff Detail

Repository
R4872 cloc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tomocafe created this revision.Jul 26 2019, 5:01 AM
tomocafe requested review of this revision.Jul 26 2019, 5:01 AM

You should update the titles on diffs in this stack so they are just Initial inclusion of cloc, Initial inclusion of perl-digest-md5, etc.

tomocafe retitled this revision from Initial inclusion of cloc Depends on D6805, D6806 Resolves T8163 to Initial inclusion of cloc.Jul 26 2019, 5:30 PM

@davidjharder Done -- I mixed up the purposes of the git commit message and the arcanist summary section. ๐Ÿ˜…

Girtablulu requested changes to this revision.Aug 5 2019, 4:52 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
23

if they are not needed you can remove them

This revision now requires changes to proceed.Aug 5 2019, 4:52 PM
tomocafe updated this revision to Diff 16521.Aug 6 2019, 3:09 AM

Remove commented out targets

JoshStrobl requested changes to this revision.Aug 30 2019, 11:13 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

See perl-moo comment

This revision now requires changes to proceed.Aug 30 2019, 11:13 AM
tomocafe updated this revision to Diff 16969.Aug 31 2019, 3:04 AM
tomocafe marked 2 inline comments as done.

Fix builddeps

JoshStrobl requested changes to this revision.Sep 3 2019, 3:58 PM
This revision now requires changes to proceed.Sep 3 2019, 3:58 PM
tomocafe updated this revision to Diff 18273.Nov 10 2019, 9:58 PM

Fix differential

tomocafe updated this revision to Diff 18274.Nov 10 2019, 10:05 PM

Update version

tomocafe added a comment.EditedNov 10 2019, 10:06 PM

Forgot to update pspec... One moment.

tomocafe updated this revision to Diff 18275.Nov 10 2019, 10:15 PM

Update pspec

DataDrake requested changes to this revision.Nov 18 2019, 5:28 AM
DataDrake added a subscriber: DataDrake.

Please alphabetize rundeps.

This revision now requires changes to proceed.Nov 18 2019, 5:28 AM
tomocafe updated this revision to Diff 18403.Nov 18 2019, 2:21 PM

Alphabetize deps

DataDrake accepted this revision.Dec 22 2019, 5:00 AM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 22 2019, 5:02 AM
Closed by commit R4872:b28f424d03a3: Initial inclusion of cloc (authored by tomocafe, committed by DataDrake). ยท Explain Why
This revision was automatically updated to reflect the committed changes.