tomocafe retitled this revision from Initial inclusion of perl-moo Depends on D6802, D6803 Needed for cloc, see T8163 to Initial inclusion of perl-moo.Jul 26 2019, 5:31 PM

JoshStrobl requested changes to this revision.Aug 30 2019, 11:12 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
13	Can be removed once the perl-class-method-modifiers has perl as a rundep.

This revision now requires changes to proceed.Aug 30 2019, 11:12 AM

Fix builddeps

You need to amend your commit and submit the full patch. Right now you're effectively submitting a patch against a non-existent master branch to remove a dep.

This revision now requires changes to proceed.Sep 3 2019, 3:56 PM

Hi @JoshStrobl,

When making the revision, I accidentally did git commit without the --amend, which created a new differential. (I abandoned those.) I later did git commit --amend in the same repository, and then arc diff. I read the instructions here, but git rebase -i HEAD~2 doesn't work.

git log shows:

commit 9683586a51428473a6e2d0bffa5ebd3e139b474a (HEAD -> master)
Author: Evan Wegley <tomocafe@pm.me>
Date:   Fri Aug 30 19:45:42 2019 -0700

    Fix builddeps
    
    Summary: Initial inclusion of perl-moo
    Depends on D6802, D6803
    Needed for cloc, see T8163
    
    Test Plan: See cloc test plan
    
    Reviewers: #triage_team
    
    Differential Revision: https://dev.getsol.us/D6804

commit 0125caf68398b32cef80696170261739736b00b3
Author: Evan Wegley <tomocafe@pm.me>
Date:   Thu Jul 25 21:54:35 2019 -0700

    Initial inclusion of perl-moo Depends on D6802, D6803 Needed for cloc, see T8163
    
    Summary: Add perl dependency of cloc
    
    Test Plan: See cloc test plan
    
    Reviewers: #triage_team
    
    Differential Revision: https://dev.getsol.us/D6804

Can you advise on how to proceed? Sorry for the trouble. :)